Populate predicate map before any other variable is translated - #256
Open
maarquitos14 wants to merge 5 commits into
Open
Populate predicate map before any other variable is translated#256maarquitos14 wants to merge 5 commits into
maarquitos14 wants to merge 5 commits into
Conversation
AlexVlx
reviewed
Aug 12, 2026
| DbgTran->transDebugInst(EI); | ||
| } | ||
|
|
||
| // Populate the feature predicate map before translating any variables, |
Contributor
There was a problem hiding this comment.
The idea seems fine but always iterating twice seems not quite ideal. We could consider two things here:
- change to an associative container;
- keep the original loop, and only go and do the initialisation either when we encounter the map or for whichever variable comes first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-TU HIP programs we can find
__clang_gpu_used_externalwhich appears beforellvm.amdgcn.feature.predicate.idsand it recursively triggers function translation which ends up resolving spec constants against an emptyFeaturePredicateMap. This patch populates the map before translating any variable.