-
Notifications
You must be signed in to change notification settings - Fork 23
Release v2.2 bugfixes megatron ifu #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release_v2.2_rocm
Are you sure you want to change the base?
Conversation
* fix Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> * added test Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * test change Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> * changed the test Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
I think it is better to create separate branch rather than using release_v2.2_rocm. |
|
Dev branch doesn't need these fixes, since they already have them
TransformerEngine/transformer_engine/pytorch/distributed.py Lines 706 to 710 in 51f74fa
This is only for release_v2.2 branch since Megatron's CI uses this specific commit. |
|
It is not a question of branch per se but rather versioning. TE 2.2 was released a while ago. So changes on top of that should be versioned like 2.2.post0 or something like this. |
|
Yeah that makes sense! I'll bump the version to 2.2.post0. |
Description
This PR fixes some bugs in the release v2.2 branch that I found when working on the Megatron IFU r0.15.0.
Type of change
Changes
Checklist: