Skip to content

fix: allow non root user generate and validate the cdi spec #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shiv-tyagi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: allow non root user generate and validate the cdi spec #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5381b2f
fix: allow non root user generate and validate the cdi spec
shiv-tyagi Jan 14, 2026
5a6be2f
fix: pass full file path to the cdi.specPath in cdi_test
shiv-tyagi Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions cmd/amd-ctk/cdi/generate/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ package generate

import (
"fmt"
"os/user"
"path/filepath"
"strings"

Expand Down Expand Up @@ -63,11 +62,6 @@ func AddNewCommand() *cli.Command {
}

func validateGenOptions(c *cli.Context, genOptions *generateOptions) error {
curUser, err := user.Current()
if err != nil || curUser.Uid != "0" {
return fmt.Errorf("Permission denied: Not running as root")
}

out, err := filepath.Abs(genOptions.output)
if err != nil {
return fmt.Errorf("incorrect output file, Err: %v", err)
Expand Down
6 changes: 0 additions & 6 deletions cmd/amd-ctk/cdi/validate/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ package validate

import (
"fmt"
"os/user"
"path/filepath"
"strings"

Expand Down Expand Up @@ -63,11 +62,6 @@ func AddNewCommand() *cli.Command {
}

func validateValOptions(c *cli.Context, valOptions *validateOptions) error {
curUser, err := user.Current()
if err != nil || curUser.Uid != "0" {
return fmt.Errorf("Permission denied: Not running as root")
}

out, err := filepath.Abs(valOptions.cdiSpecPath)
if err != nil {
return fmt.Errorf("Incorrect CDI spec file, Error: %v", err)
Expand Down
2 changes: 1 addition & 1 deletion internal/cdi/cdi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func TestInterface(t *testing.T) {
err := cdi.GenerateSpec()
Assert(t, err == nil, fmt.Sprintf("failed to generate cdi spec, Err: %v", err))

cdi.specPath = "/tmp/"
cdi.specPath = t.TempDir() + "/amd.json"
err = cdi.WriteSpec()
Assert(t, err == nil, fmt.Sprintf("WriteSpec() returned error %v", err))

Expand Down