docs: add post-PR Copilot review loop and fix inline-code span#263
Merged
Conversation
Document the after-create workflow in the pr-workflow skill: wait for all Copilot comments, evaluate each on merits, fix the worthwhile ones, then resolve every thread with either a fix+SHA reply or a won't-fix rationale (GraphQL recipes included, since REST 404s on review-thread comments). Also fix a CLAUDE.md inline-code span that was split across a newline (markdown can't render a multi-line backtick span) by using two separate spans. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates repo documentation to (1) formalize a post-PR-creation loop for handling GitHub Copilot review comments/threads and (2) fix a Markdown inline-code rendering issue in the core contributor guidance.
Changes:
- Added an “After creating a PR: handle the Copilot review” section to the
pr-workflowskill, including CLI/GraphQL recipes for listing/replying/resolving review threads. - Fixed a broken inline-code span in
CLAUDE.mdby splitting a backtick span that was previously split across a newline.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
CLAUDE.md |
Fixes Markdown inline-code formatting for the fetch/reset guidance. |
.claude/skills/pr-workflow/SKILL.md |
Documents a post-PR Copilot review workflow and provides example commands for managing review threads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add a "Before creating a PR: quality gate" section to the pr-workflow skill (simplify/production-ready, /code-review and apply, run relevant pytests, then commit). Reword the GraphQL aside to correctly state that thread resolution and isResolved are unavailable via REST (replies are available over REST), and note the reviewThreads(first:50) query is not exhaustive on large PRs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a documented post-create Copilot review workflow to the
pr-workflowskill, and fixes the one remaining Copilot finding from #262 (an inline-code span split across a newline inCLAUDE.md).What changed
.claude/skills/pr-workflow/SKILL.md— new "After creating a PR: handle the Copilot review" section: wait for all Copilot comments to land (and integrate any Copilot auto-push commits), evaluate each comment on its merits, fix the worthwhile ones, then resolve every thread — fixed threads get a commit-SHA reply, won't-fix threads get a written rationale. Includes GraphQL recipes for listing/resolving threads, since the REST/comments/<id>endpoint 404s on review-thread comments.CLAUDE.md— the fetch+reset guidance previously sat inside a single backtick span broken across a line, which markdown can't render. Split into two separate inline-code spans.Test plan
pre-commit run -a(ran via commit hooks; markdownlint and file checks passed)