fix(devcontainer): align AITER ROCm index with PyTorch ROCm version#268
Closed
demandal25 wants to merge 1 commit into
Closed
fix(devcontainer): align AITER ROCm index with PyTorch ROCm version#268demandal25 wants to merge 1 commit into
demandal25 wants to merge 1 commit into
Conversation
Default AITER_ROCM_VERSION to ROCM_VERSION so the devcontainer installs both packages from the same ROCm release, avoiding binary mismatches. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the ROCm devcontainer build configuration so amd-aiter is installed from the same ROCm release stream as the ROCm-enabled PyTorch wheel, reducing the risk of runtime binary incompatibilities.
Changes:
- Default
AITER_ROCM_VERSIONto${ROCM_VERSION}in the ROCm devcontainer Dockerfile so the AITER PyPI index tracks the selected ROCm version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The devcontainer Dockerfile installed PyTorch from
rocm-rel-7.2but AITER from therocm-7.1.1PyPI index. That mismatch can cause binary incompatibilities between the two packages at runtime.What changed
.devcontainer/rocm/Dockerfile— defaultAITER_ROCM_VERSIONto${ROCM_VERSION}so both packages are pulled from the same ROCm release. The arg can still be overridden at build time if needed.Test plan
pre-commit run -a(via commit hook on staged file)Made with Cursor