Create a subregclass from SGPR for the call clobbered register pairs.#160
Draft
cdevadas wants to merge 1 commit intoROCm:amd-commonfrom
Draft
Create a subregclass from SGPR for the call clobbered register pairs.#160cdevadas wants to merge 1 commit intoROCm:amd-commonfrom
cdevadas wants to merge 1 commit intoROCm:amd-commonfrom
Conversation
Use this register class in the return instruction for the operand that holds the return address.
cdevadas
commented
Jun 20, 2019
| LiveRegs.addLiveIns(MBB); | ||
|
|
||
| // to avoid clobbering the registers used in the return instruction. | ||
| if (MBBI->getOpcode() == AMDGPU::S_SETPC_B64_return && |
Author
There was a problem hiding this comment.
I assume it is safe to check for the opcode first, and then get the registers.
Not sure whether I should check the operand is register.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this new register class in the return instruction for the operand that holds the return address.