[AMDGPU] OCL12 Adapter: avoid processing of special C++ functions#50
Open
vpykhtin wants to merge 1 commit intoROCm:amd-commonfrom
vpykhtin:amd-common
Open
[AMDGPU] OCL12 Adapter: avoid processing of special C++ functions#50vpykhtin wants to merge 1 commit intoROCm:amd-commonfrom vpykhtin:amd-common
vpykhtin wants to merge 1 commit intoROCm:amd-commonfrom
vpykhtin:amd-common
Conversation
…whether _Z is followed by the namelength
|
Can you add a test case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids processing of functions like _ZdlPv ( void operator delete(void *)) by the OCL12 Adapter pass which fixes failure within HCC compiler. Special C++ functions has predefined names which doesn't start with namelength after _Z prefix. So this fix: