[Driver][MISC] Update ADC/PWM #11003

GuEe-GUI · 2025-12-02T05:34:10Z

拉取/合并请求描述：(PR description)

[

Fixup ADC some error.
Enable rt_pwm_get API.
Make Kconfig(ADC/PWM) import for DM.

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Signed-off-by: GuEe-GUI <2991707448@qq.com>

github-actions · 2025-12-02T05:34:18Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：misc_dd
设置PR number为 \ Set the PR number to：11003

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 misc_dd 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the misc_dd branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2025-12-02T05:34:24Z

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: Maihuanyi

Changed Files (Click to expand)

components/drivers/include/drivers/dev_pwm.h
components/drivers/misc/Kconfig
components/drivers/misc/adc.c
components/drivers/misc/rt_drv_pwm.c

📊 Current Review Status (Last Updated: 2025-12-08 11:36 CST)

⌛ Maihuanyi Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

GuEe-GUI · 2025-12-04T04:15:12Z

@Maihuanyi @Rbb666

Rbb666 · 2025-12-07T15:04:28Z

感觉DM相关实现是不是放到类似 components/drivers/DM 文件夹下面统一管理会好一些？

Copilot

Pull request overview

This PR updates ADC and PWM drivers with bug fixes and Device Manager (DM) integration support. The changes include fixing ADC error handling, enabling the PWM get API for public use, and adding Kconfig support for DM-based driver configurations.

Key Changes:

Fixed ADC error code initialization from positive to negative value (correct RT-Thread convention)
Exposed rt_pwm_get() function from static to public API with header declaration
Added conditional Kconfig entries for DM support in ADC and PWM drivers

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
components/drivers/misc/adc.c	Fixed error code initialization to `-RT_ERROR`, initialized voltage variable, and updated type casting for channel parameter
components/drivers/misc/rt_drv_pwm.c	Changed `rt_pwm_get()` from static to public function
components/drivers/include/drivers/dev_pwm.h	Added public declaration for `rt_pwm_get()` function with documentation
components/drivers/misc/Kconfig	Changed ADC/PWM config to menuconfig and added conditional DM Kconfig imports

components/drivers/misc/rt_drv_pwm.c

components/drivers/misc/adc.c

components/drivers/include/drivers/dev_pwm.h

components/drivers/misc/adc.c

GuEe-GUI · 2025-12-08T03:30:32Z

感觉DM相关实现是不是放到类似 components/drivers/DM 文件夹下面统一管理会好一些？

目前除了对 Kconfig 的修改，其他地方和 DM 没有关系

1. Fixup error no. 2. Fixup type of control for args. 3. Fixup value no init. Signed-off-by: GuEe-GUI <2991707448@qq.com>

Signed-off-by: GuEe-GUI <2991707448@qq.com>

GuEe-GUI · 2025-12-08T03:36:21Z

@Rbb666 AI 相关要求已修改

[DM][MISC] Make Kconfig(ADC/PWM) import for DM

a774ea7

Signed-off-by: GuEe-GUI <2991707448@qq.com>

github-actions bot added Component component: drivers/misc component: drivers labels Dec 2, 2025

GuEe-GUI force-pushed the misc_dd branch from b29c389 to cbe4d2b Compare December 2, 2025 05:37

Rbb666 requested a review from Copilot December 7, 2025 15:00

Copilot started reviewing on behalf of Rbb666 December 7, 2025 15:02 View session

Rbb666 approved these changes Dec 7, 2025

View reviewed changes

Copilot AI reviewed Dec 7, 2025

View reviewed changes

components/drivers/misc/rt_drv_pwm.c Show resolved Hide resolved

components/drivers/misc/adc.c Outdated Show resolved Hide resolved

components/drivers/include/drivers/dev_pwm.h Outdated Show resolved Hide resolved

components/drivers/misc/adc.c Outdated Show resolved Hide resolved

GuEe-GUI added 2 commits December 8, 2025 11:35

[Driver][MISC][ADC] Fixup ADC

5507cb9

1. Fixup error no. 2. Fixup type of control for args. 3. Fixup value no init. Signed-off-by: GuEe-GUI <2991707448@qq.com>

[Driver][MISC][PWM] Enable rt_pwm_get API

24ba20b

Signed-off-by: GuEe-GUI <2991707448@qq.com>

GuEe-GUI force-pushed the misc_dd branch from cbe4d2b to 24ba20b Compare December 8, 2025 03:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Driver][MISC] Update ADC/PWM #11003

[Driver][MISC] Update ADC/PWM #11003

GuEe-GUI commented Dec 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

GuEe-GUI commented Dec 4, 2025

Uh oh!

Rbb666 commented Dec 7, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GuEe-GUI commented Dec 8, 2025

Uh oh!

GuEe-GUI commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[Driver][MISC] Update ADC/PWM #11003

Are you sure you want to change the base?

[Driver][MISC] Update ADC/PWM #11003

Conversation

GuEe-GUI commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Dec 2, 2025

🛠 操作步骤 | Steps

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: components

📊 Current Review Status (Last Updated: 2025-12-08 11:36 CST)

📝 Review Instructions

Uh oh!

GuEe-GUI commented Dec 4, 2025

Uh oh!

Rbb666 commented Dec 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GuEe-GUI commented Dec 8, 2025

Uh oh!

GuEe-GUI commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GuEe-GUI commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading