Add backward compatiblity code for <termio.h>.#482
Add backward compatiblity code for <termio.h>.#482jpc-lip6 wants to merge 1 commit intoRTimothyEdwards:masterfrom
Conversation
The backward compatibility code for <termio.h> has been removed starting from GLIBC 2.42. So it starts to fail on some bleeding edge distributions like openSUSE Tumbleweed. We took back the code removed from the GLIBC and put it back inside txInput.c.
|
Thanks for the input! @dlmiles : You have a good understanding of OS compatibility issues. Any comment on the GLIBC changes? |
|
@jpc-lip6 Please see this issue and comment #435 (comment) There is a commit listed in this comment, please apply this and see if it resolves your build issue. Adding a private copy of The commit is a better approach as it, reduces lines of code, cleans up the proliferation of the header file, it should still work in theory (we have no CI to test) on systems that have one of the two legacy termios methods (termio.h/sgtty.h) which different platforms converted to termios.h in different ways. Can you please at least cite the |
|
I confirm that your commit #435 works with the GLIBC 2.42. When encountering those kind of deprecation problems, we have two ways of solving it:
The question here may be why it was not merged into trunk ? Yes, next time I will provides the build log. My builds, and their logs can be found here : https://build.opensuse.org/package/show/home:jpc-lip6/magic (the faulty one are no longer there after I made the correction). |
The backward compatibility code for <termio.h> has been removed starting from GLIBC 2.42. So it starts to fail on some bleeding edge distributions like openSUSE Tumbleweed. We took back the code removed from the GLIBC and put it back inside txInput.c.