Open
Conversation
Sync with sdl/Sdl-Community master
The plugin does invoke translate endpoint per each segment. This approach is not optimal. DeepL API allow to translate up to 50 segments at once. Translating more segments at once reduces pre-translation time by up to 60% (based on my tests). In addition, to make translation process more reliable I've added translation retrying routine in case of some http status codes received from DeepL Service.
Author
|
Bump. Is this repo still alive? |
Contributor
|
Hi @KamilChlodek , sorry for taking so long to followup and review this PR; love these changes, but the PR is out of sync with the latest version of the repo. Can you sync the PR against master again? it's already been a few years now since you posted this PR |
Author
|
Sure, no problem. I'll try to do it next week. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin does invoke translate endpoint per each segment. This approach is not optimal. DeepL API allow to translate up to 50 segments at once. Translating more segments at once reduces pre-translation time by up to 60% (based on my tests). In addition, to make translation process more reliable I've added translation retrying routine in case of some http status codes received from DeepL Service.