XliffCompare: Make non-breaking space edits visible in report#1044
Open
murxh wants to merge 6 commits intoRWS:masterfrom
Open
XliffCompare: Make non-breaking space edits visible in report#1044murxh wants to merge 6 commits intoRWS:masterfrom
murxh wants to merge 6 commits intoRWS:masterfrom
Conversation
UNNECESSARY AND POSSIBLE NULL REFERENCE EXCEPTION: SourceFile might be null in a WorldServer project
ProjectFileService.GetProjectFiles fails silently if it encounters invalid xml chars (like 0x1C, 0x1E, ...), resulting in an empty export file without any warning to the user
An easy fix is to use XmlReaderSettings { CheckCharacters = false };
StudioViews.Services.ProjectFileService: Update GetProjectFiles to avoid silent fail
Impertatore
approved these changes
Nov 19, 2025
Contributor
|
Hi @murxh , srry for taking so long to review this PR. I approve yr changes, but it's been so long the PR is not in sync; can you please resolve the conflicts and push the updates again? |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far edits where a space had been replaced with a nbsp (or vice versa) are not shown. This fix addresses this by creating a 'word' when one or more non-breaking spaces are encountered.