Fix panic when using linear or ZOH resampling#1
Open
BillyDM wants to merge 2 commits intoRamiHg:masterfrom
Open
Fix panic when using linear or ZOH resampling#1BillyDM wants to merge 2 commits intoRamiHg:masterfrom
BillyDM wants to merge 2 commits intoRamiHg:masterfrom
Conversation
Author
|
Any chance of this being merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently linear and ZOH resampling causes a panic when using more than one channel because it tries to index the
last_valuearray out-of-bounds. However, this is intended in the C version since this struct is used as a variable length array. The fix is to just use unchecked array indexing in Rust.Also, the compiler was marking the
#[no_mangle]on some of the methods as a warning, and it even mentioned this will be a hard error in future versions of the Rust compiler, so I went ahead and removed those as well.