Open
Conversation
npx npm-check-updates -u && npm install --ignore-scripts
Author
|
I notice now that Unfortunately I don't have time to handle this, so @RamyElkest if you can find the time, please update |
Owner
|
@hugojosefson many thanks for taking the time. The DockerFile was added recently so travis wasn't updated, I'll handle it. Thanks again 👍 |
Author
|
Thanks @RamyElkest 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades a bunch of dependencies, as well as makes
make dockerrun both the build and the tests.How to test
Building and testing in Docker
Needs only Docker installed, not Node.js.
Building and testing using Node.js
I have successfully run the above commands using:
Docker version 19.03.8, build afacb8b7f0Node.js v14.1.0Node.js v12.16.3Node.js v10.20.1Node.js v8.17.0I have not tested the results in an application, but am submitting my improvements here because of hugojosefson@0dbdf25#commitcomment-38849952.
Please test before merging :)