This repository was archived by the owner on Aug 10, 2024. It is now read-only.
Adds RSS Item Categories as ParsedArticle Tags#69
Open
Sonictherocketman wants to merge 1 commit intoRanchero-Software:mainfrom
Open
Adds RSS Item Categories as ParsedArticle Tags#69Sonictherocketman wants to merge 1 commit intoRanchero-Software:mainfrom
Sonictherocketman wants to merge 1 commit intoRanchero-Software:mainfrom
Conversation
Collaborator
|
I wouldn’t be opposed to adding support for categories/tags — but we should support Atom as well as RSS. We should use a single tag datatype that works for both types of feeds. (And for JSON Feed as well. I don’t recall offhand what JSON Feed tags look like.) |
Author
|
I can look into this when I get the chance. Finding valid test fixtures in the wild might be tricky, but I'll make something work. IIRC, the parser for JSON feeds already support tags (which is how I found this issue in the first place). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that RSS Categories were not being parsed as tags. From my experience they are effectively interchangeable, so I included them as part of ParsedArticle.
I wasn't able to find an example Atom feed (either in the fixtures or cursorily browsing the web) so I didn't include parsing categories for Atom feeds in this change. It also seems like the Atom spec is a bit more involved -- categories in Atom aren't simple strings.
I've added a new test and it does pass. I apologize if my changes aren't paradigmatic; my Obj-C is very rusty.
btw, I'm using RSParser in a new app I'm developing and it's been a pleasure to use. Keep up the good work!