cleanup post / edit et fix post:message (PR PROPRE)#10
Open
Lantea-Git wants to merge 1 commit intoRand0max:masterfrom
Open
cleanup post / edit et fix post:message (PR PROPRE)#10Lantea-Git wants to merge 1 commit intoRand0max:masterfrom
Lantea-Git wants to merge 1 commit intoRand0max:masterfrom
Conversation
cleanup post / edit et fix post:message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplification de la requête post ou c
Utilisation de formData plutôt que de boundary.
Fresh hash est trouvable dans le payload comme topicId et forumId (il a juste un nom différent).
(les regex pour catch le topic id est forum id ne sont pas/plus utile. dette tech.)
Utilisation de lurl du msg présent dans la réponse réseau en JSON. (Désolé, j'ai reouvert un pr car habitude de XHR qui renvoie directement la réponse sans parse de json derrière.).
Le force update à 1000 ms ne sert à rien dans postjvcmsg : quand le serv repond (en post seulement => il a déjà l'url du msg donc le backend est déjà pret).
Edition :
Pour l'édition, le texte est directement intégré dans .txt-msg , pour éviter ça force la mise en forme le temps que le force update prenne effet.
Bref dégrossissement. et restauration de la fonction event post message
clean up quoi .
J'ai pas tout test c'est issu d'un fork perso, mais dans l'idée ça marche, à la limite 1 ou 2 lignes à fix mais fleme.