Improve Benchmarking

build.rs

@@ -23,7 +23,9 @@ fn main() {
 
     // Collect all Rust source files in the workspace
     let rust_files = collect_rust_files(workspace_root);
-
+    for error in RequireExtrinsicBenchmarks::lint_workspace(workspace_root) {
+        println!("cargo:warning={error}");
+    }
     // Channel used to communicate errors back to the main thread from the parallel processing
     // as we process each Rust file
     let (tx, rx) = channel();

docs/tx/add-stake-limit.mdx

@@ -74,7 +74,7 @@ result = sub.execute_tool("add_stake_limit", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.add_stake_limit` — [`pallets/subtensor/src/macros/dispatches.rs#L1407`](/code/pallets/subtensor/src/macros/dispatches.rs#L1407):
+`SubtensorModule.add_stake_limit` — [`pallets/subtensor/src/macros/dispatches.rs#L1393`](/code/pallets/subtensor/src/macros/dispatches.rs#L1393):
 
 ```rust
 #[pallet::call_index(88)]

docs/tx/add-stake.mdx

@@ -79,7 +79,7 @@ result = sub.execute_tool("add_stake", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.add_stake` — [`pallets/subtensor/src/macros/dispatches.rs#L569`](/code/pallets/subtensor/src/macros/dispatches.rs#L569):
+`SubtensorModule.add_stake` — [`pallets/subtensor/src/macros/dispatches.rs#L561`](/code/pallets/subtensor/src/macros/dispatches.rs#L561):
 
 ```rust
 #[pallet::call_index(2)]
@@ -96,7 +96,7 @@ pub fn add_stake(
 
 Delegates to [`do_add_stake`](/code/pallets/subtensor/src/staking/add_stake.rs#L30).
 
-`SubtensorModule.add_stake_limit` — [`pallets/subtensor/src/macros/dispatches.rs#L1407`](/code/pallets/subtensor/src/macros/dispatches.rs#L1407):
+`SubtensorModule.add_stake_limit` — [`pallets/subtensor/src/macros/dispatches.rs#L1393`](/code/pallets/subtensor/src/macros/dispatches.rs#L1393):
 
 ```rust
 #[pallet::call_index(88)]

docs/tx/announce-coldkey-swap.mdx

@@ -72,7 +72,7 @@ result = sub.execute_tool("announce_coldkey_swap", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.announce_coldkey_swap` — [`pallets/subtensor/src/macros/dispatches.rs#L2006`](/code/pallets/subtensor/src/macros/dispatches.rs#L2006):
+`SubtensorModule.announce_coldkey_swap` — [`pallets/subtensor/src/macros/dispatches.rs#L1987`](/code/pallets/subtensor/src/macros/dispatches.rs#L1987):
 
 ```rust
 #[pallet::call_index(125)]

docs/tx/associate-evm-key.mdx

@@ -78,7 +78,7 @@ result = sub.execute_tool("associate_evm_key", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.associate_evm_key` — [`pallets/subtensor/src/macros/dispatches.rs#L1593`](/code/pallets/subtensor/src/macros/dispatches.rs#L1593):
+`SubtensorModule.associate_evm_key` — [`pallets/subtensor/src/macros/dispatches.rs#L1579`](/code/pallets/subtensor/src/macros/dispatches.rs#L1579):
 
 ```rust
 #[pallet::call_index(93)]

docs/tx/associate-hotkey.mdx

@@ -62,7 +62,7 @@ result = sub.execute_tool("associate_hotkey", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.try_associate_hotkey` — [`pallets/subtensor/src/macros/dispatches.rs#L1535`](/code/pallets/subtensor/src/macros/dispatches.rs#L1535):
+`SubtensorModule.try_associate_hotkey` — [`pallets/subtensor/src/macros/dispatches.rs#L1521`](/code/pallets/subtensor/src/macros/dispatches.rs#L1521):
 
 ```rust
 #[pallet::call_index(91)]

docs/tx/burned-register.mdx

@@ -69,7 +69,7 @@ result = sub.execute_tool("burned_register", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.burned_register` — [`pallets/subtensor/src/macros/dispatches.rs#L826`](/code/pallets/subtensor/src/macros/dispatches.rs#L826):
+`SubtensorModule.burned_register` — [`pallets/subtensor/src/macros/dispatches.rs#L818`](/code/pallets/subtensor/src/macros/dispatches.rs#L818):
 
 ```rust
 #[pallet::call_index(7)]

docs/tx/claim-root.mdx

@@ -66,7 +66,7 @@ result = sub.execute_tool("claim_root", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.claim_root` — [`pallets/subtensor/src/macros/dispatches.rs#L1910`](/code/pallets/subtensor/src/macros/dispatches.rs#L1910):
+`SubtensorModule.claim_root` — [`pallets/subtensor/src/macros/dispatches.rs#L1891`](/code/pallets/subtensor/src/macros/dispatches.rs#L1891):
 
 ```rust
 #[pallet::call_index(121)]

docs/tx/clear-coldkey-swap-announcement.mdx

@@ -62,13 +62,11 @@ result = sub.execute_tool("clear_coldkey_swap_announcement", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.clear_coldkey_swap_announcement` — [`pallets/subtensor/src/macros/dispatches.rs#L2213`](/code/pallets/subtensor/src/macros/dispatches.rs#L2213):
+`SubtensorModule.clear_coldkey_swap_announcement` — [`pallets/subtensor/src/macros/dispatches.rs#L2186`](/code/pallets/subtensor/src/macros/dispatches.rs#L2186):
 
 ```rust
 #[pallet::call_index(133)]
-#[pallet::weight(Weight::from_parts(17_890_000, 0)
-.saturating_add(T::DbWeight::get().reads(2))
-.saturating_add(T::DbWeight::get().writes(1)))]
+#[pallet::weight(<T as crate::pallet::Config>::WeightInfo::clear_coldkey_swap_announcement())]
 pub fn clear_coldkey_swap_announcement(origin: OriginFor<T>) -> DispatchResult {
     let who = ensure_signed(origin)?;
     let now = <frame_system::Pallet<T>>::block_number();

docs/tx/commit-weights.mdx

@@ -70,30 +70,28 @@ result = sub.execute_tool("commit_weights", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.commit_timelocked_mechanism_weights` — [`pallets/subtensor/src/macros/dispatches.rs#L1869`](/code/pallets/subtensor/src/macros/dispatches.rs#L1869):
+`SubtensorModule.commit_timelocked_mechanism_weights` — [`pallets/subtensor/src/macros/dispatches.rs#L1852`](/code/pallets/subtensor/src/macros/dispatches.rs#L1852):
 
 ```rust
-        #[pallet::call_index(118)]
-        #[pallet::weight((Weight::from_parts(84_020_000, 0)
-		.saturating_add(T::DbWeight::get().reads(9_u64))
-		.saturating_add(T::DbWeight::get().writes(2)), DispatchClass::Normal, Pays::No))]
-        pub fn commit_timelocked_mechanism_weights(
-            origin: OriginFor<T>,
-            netuid: NetUid,
-            mecid: MechId,
-            commit: BoundedVec<u8, ConstU32<MAX_CRV3_COMMIT_SIZE_BYTES>>,
-            reveal_round: u64,
-            commit_reveal_version: u16,
-        ) -> DispatchResult {
-            Self::do_commit_timelocked_mechanism_weights(
-                origin,
-                netuid,
-                mecid,
-                commit,
-                reveal_round,
-                commit_reveal_version,
-            )
-        }
+#[pallet::call_index(118)]
+#[pallet::weight((<T as Config>::WeightInfo::commit_timelocked_mechanism_weights(), DispatchClass::Normal, Pays::No))]
+pub fn commit_timelocked_mechanism_weights(
+    origin: OriginFor<T>,
+    netuid: NetUid,
+    mecid: MechId,
+    commit: BoundedVec<u8, ConstU32<MAX_CRV3_COMMIT_SIZE_BYTES>>,
+    reveal_round: u64,
+    commit_reveal_version: u16,
+) -> DispatchResult {
+    Self::do_commit_timelocked_mechanism_weights(
+        origin,
+        netuid,
+        mecid,
+        commit,
+        reveal_round,
+        commit_reveal_version,
+    )
+}
 ```
 
 Delegates to [`do_commit_timelocked_mechanism_weights`](/code/pallets/subtensor/src/subnets/weights.rs#L263).

docs/tx/decrease-take.mdx

@@ -64,7 +64,7 @@ result = sub.execute_tool("decrease_take", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.decrease_take` — [`pallets/subtensor/src/macros/dispatches.rs#L500`](/code/pallets/subtensor/src/macros/dispatches.rs#L500):
+`SubtensorModule.decrease_take` — [`pallets/subtensor/src/macros/dispatches.rs#L492`](/code/pallets/subtensor/src/macros/dispatches.rs#L492):
 
 ```rust
 #[pallet::call_index(65)]

docs/tx/dispute-coldkey-swap.mdx

@@ -63,7 +63,7 @@ result = sub.execute_tool("dispute_coldkey_swap", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.dispute_coldkey_swap` — [`pallets/subtensor/src/macros/dispatches.rs#L2075`](/code/pallets/subtensor/src/macros/dispatches.rs#L2075):
+`SubtensorModule.dispute_coldkey_swap` — [`pallets/subtensor/src/macros/dispatches.rs#L2056`](/code/pallets/subtensor/src/macros/dispatches.rs#L2056):
 
 ```rust
 #[pallet::call_index(127)]

docs/tx/increase-take.mdx

@@ -65,7 +65,7 @@ result = sub.execute_tool("increase_take", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.increase_take` — [`pallets/subtensor/src/macros/dispatches.rs#L533`](/code/pallets/subtensor/src/macros/dispatches.rs#L533):
+`SubtensorModule.increase_take` — [`pallets/subtensor/src/macros/dispatches.rs#L525`](/code/pallets/subtensor/src/macros/dispatches.rs#L525):
 
 ```rust
 #[pallet::call_index(66)]

docs/tx/lock-stake.mdx

@@ -74,7 +74,7 @@ result = sub.execute_tool("lock_stake", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.lock_stake` — [`pallets/subtensor/src/macros/dispatches.rs#L2291`](/code/pallets/subtensor/src/macros/dispatches.rs#L2291):
+`SubtensorModule.lock_stake` — [`pallets/subtensor/src/macros/dispatches.rs#L2258`](/code/pallets/subtensor/src/macros/dispatches.rs#L2258):
 
 ```rust
 #[pallet::call_index(136)]

docs/tx/move-lock.mdx

@@ -68,7 +68,7 @@ result = sub.execute_tool("move_lock", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.move_lock` — [`pallets/subtensor/src/macros/dispatches.rs#L2315`](/code/pallets/subtensor/src/macros/dispatches.rs#L2315):
+`SubtensorModule.move_lock` — [`pallets/subtensor/src/macros/dispatches.rs#L2282`](/code/pallets/subtensor/src/macros/dispatches.rs#L2282):
 
 ```rust
 #[pallet::call_index(137)]

docs/tx/move-stake.mdx

@@ -77,7 +77,7 @@ result = sub.execute_tool("move_stake", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.move_stake` — [`pallets/subtensor/src/macros/dispatches.rs#L1271`](/code/pallets/subtensor/src/macros/dispatches.rs#L1271):
+`SubtensorModule.move_stake` — [`pallets/subtensor/src/macros/dispatches.rs#L1257`](/code/pallets/subtensor/src/macros/dispatches.rs#L1257):
 
 ```rust
 #[pallet::call_index(85)]

docs/tx/register-leased-network.mdx

@@ -69,7 +69,7 @@ result = sub.execute_tool("register_leased_network", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.register_leased_network` — [`pallets/subtensor/src/macros/dispatches.rs#L1688`](/code/pallets/subtensor/src/macros/dispatches.rs#L1688):
+`SubtensorModule.register_leased_network` — [`pallets/subtensor/src/macros/dispatches.rs#L1673`](/code/pallets/subtensor/src/macros/dispatches.rs#L1673):
 
 ```rust
 #[pallet::call_index(110)]

docs/tx/register-subnet.mdx

@@ -70,7 +70,7 @@ result = sub.execute_tool("register_subnet", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.register_network` — [`pallets/subtensor/src/macros/dispatches.rs#L1016`](/code/pallets/subtensor/src/macros/dispatches.rs#L1016):
+`SubtensorModule.register_network` — [`pallets/subtensor/src/macros/dispatches.rs#L1004`](/code/pallets/subtensor/src/macros/dispatches.rs#L1004):
 
 ```rust
 #[pallet::call_index(59)]

docs/tx/remove-stake-limit.mdx

@@ -75,7 +75,7 @@ result = sub.execute_tool("remove_stake_limit", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.remove_stake_limit` — [`pallets/subtensor/src/macros/dispatches.rs#L1460`](/code/pallets/subtensor/src/macros/dispatches.rs#L1460):
+`SubtensorModule.remove_stake_limit` — [`pallets/subtensor/src/macros/dispatches.rs#L1446`](/code/pallets/subtensor/src/macros/dispatches.rs#L1446):
 
 ```rust
 #[pallet::call_index(89)]

docs/tx/remove-stake.mdx

@@ -79,7 +79,7 @@ result = sub.execute_tool("remove_stake", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.remove_stake` — [`pallets/subtensor/src/macros/dispatches.rs#L603`](/code/pallets/subtensor/src/macros/dispatches.rs#L603):
+`SubtensorModule.remove_stake` — [`pallets/subtensor/src/macros/dispatches.rs#L595`](/code/pallets/subtensor/src/macros/dispatches.rs#L595):
 
 ```rust
 #[pallet::call_index(3)]
@@ -96,7 +96,7 @@ pub fn remove_stake(
 
 Delegates to [`do_remove_stake`](/code/pallets/subtensor/src/staking/remove_stake.rs#L35).
 
-`SubtensorModule.remove_stake_limit` — [`pallets/subtensor/src/macros/dispatches.rs#L1460`](/code/pallets/subtensor/src/macros/dispatches.rs#L1460):
+`SubtensorModule.remove_stake_limit` — [`pallets/subtensor/src/macros/dispatches.rs#L1446`](/code/pallets/subtensor/src/macros/dispatches.rs#L1446):
 
 ```rust
 #[pallet::call_index(89)]

docs/tx/reset-axon.mdx

@@ -62,7 +62,7 @@ result = sub.execute_tool("reset_axon", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.serve_axon` — [`pallets/subtensor/src/macros/dispatches.rs#L650`](/code/pallets/subtensor/src/macros/dispatches.rs#L650):
+`SubtensorModule.serve_axon` — [`pallets/subtensor/src/macros/dispatches.rs#L642`](/code/pallets/subtensor/src/macros/dispatches.rs#L642):
 
 ```rust
 #[pallet::call_index(4)]

docs/tx/reveal-weights.mdx

@@ -77,7 +77,7 @@ result = sub.execute_tool("reveal_weights", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.reveal_weights` — [`pallets/subtensor/src/macros/dispatches.rs#L281`](/code/pallets/subtensor/src/macros/dispatches.rs#L281):
+`SubtensorModule.reveal_weights` — [`pallets/subtensor/src/macros/dispatches.rs#L277`](/code/pallets/subtensor/src/macros/dispatches.rs#L277):
 
 ```rust
 #[pallet::call_index(97)]

docs/tx/root-register.mdx

@@ -64,7 +64,7 @@ result = sub.execute_tool("root_register", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.root_register` — [`pallets/subtensor/src/macros/dispatches.rs#L819`](/code/pallets/subtensor/src/macros/dispatches.rs#L819):
+`SubtensorModule.root_register` — [`pallets/subtensor/src/macros/dispatches.rs#L811`](/code/pallets/subtensor/src/macros/dispatches.rs#L811):
 
 ```rust
 #[pallet::call_index(62)]

docs/tx/serve-axon-tls.mdx

@@ -75,7 +75,7 @@ result = sub.execute_tool("serve_axon_tls", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.serve_axon_tls` — [`pallets/subtensor/src/macros/dispatches.rs#L716`](/code/pallets/subtensor/src/macros/dispatches.rs#L716):
+`SubtensorModule.serve_axon_tls` — [`pallets/subtensor/src/macros/dispatches.rs#L708`](/code/pallets/subtensor/src/macros/dispatches.rs#L708):
 
 ```rust
 #[pallet::call_index(40)]

docs/tx/serve-axon.mdx

@@ -72,7 +72,7 @@ result = sub.execute_tool("serve_axon", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.serve_axon` — [`pallets/subtensor/src/macros/dispatches.rs#L650`](/code/pallets/subtensor/src/macros/dispatches.rs#L650):
+`SubtensorModule.serve_axon` — [`pallets/subtensor/src/macros/dispatches.rs#L642`](/code/pallets/subtensor/src/macros/dispatches.rs#L642):
 
 ```rust
 #[pallet::call_index(4)]

docs/tx/serve-prometheus.mdx

@@ -69,7 +69,7 @@ result = sub.execute_tool("serve_prometheus", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.serve_prometheus` — [`pallets/subtensor/src/macros/dispatches.rs#L758`](/code/pallets/subtensor/src/macros/dispatches.rs#L758):
+`SubtensorModule.serve_prometheus` — [`pallets/subtensor/src/macros/dispatches.rs#L750`](/code/pallets/subtensor/src/macros/dispatches.rs#L750):
 
 ```rust
 #[pallet::call_index(5)]

docs/tx/set-auto-stake.mdx

@@ -67,7 +67,7 @@ result = sub.execute_tool("set_auto_stake", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.set_coldkey_auto_stake_hotkey` — [`pallets/subtensor/src/macros/dispatches.rs#L1801`](/code/pallets/subtensor/src/macros/dispatches.rs#L1801):
+`SubtensorModule.set_coldkey_auto_stake_hotkey` — [`pallets/subtensor/src/macros/dispatches.rs#L1786`](/code/pallets/subtensor/src/macros/dispatches.rs#L1786):
 
 ```rust
 #[pallet::call_index(114)]

docs/tx/set-childkey-take.mdx

@@ -67,7 +67,7 @@ result = sub.execute_tool("set_childkey_take", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.set_childkey_take` — [`pallets/subtensor/src/macros/dispatches.rs#L935`](/code/pallets/subtensor/src/macros/dispatches.rs#L935):
+`SubtensorModule.set_childkey_take` — [`pallets/subtensor/src/macros/dispatches.rs#L927`](/code/pallets/subtensor/src/macros/dispatches.rs#L927):
 
 ```rust
 #[pallet::call_index(75)]

docs/tx/set-children.mdx

@@ -79,22 +79,20 @@ result = sub.execute_tool("set_children", {...}, wallet)
 
 ## On-chain implementation
 
-`SubtensorModule.set_children` — [`pallets/subtensor/src/macros/dispatches.rs#L1093`](/code/pallets/subtensor/src/macros/dispatches.rs#L1093):
+`SubtensorModule.set_children` — [`pallets/subtensor/src/macros/dispatches.rs#L1079`](/code/pallets/subtensor/src/macros/dispatches.rs#L1079):
 
 ```rust
-        #[pallet::call_index(67)]
-        #[pallet::weight((Weight::from_parts(119_000_000, 0)
-		.saturating_add(T::DbWeight::get().reads(6))
-		.saturating_add(T::DbWeight::get().writes(31)), DispatchClass::Normal, Pays::Yes))]
-        pub fn set_children(
-            origin: OriginFor<T>,
-            hotkey: T::AccountId,
-            netuid: NetUid,
-            children: Vec<(u64, T::AccountId)>,
-        ) -> DispatchResultWithPostInfo {
-            Self::do_schedule_children(origin, hotkey, netuid, children)?;
-            Ok(().into())
-        }
+#[pallet::call_index(67)]
+#[pallet::weight((<T as Config>::WeightInfo::set_children(children.len() as u32), DispatchClass::Normal, Pays::Yes))]
+pub fn set_children(
+    origin: OriginFor<T>,
+    hotkey: T::AccountId,
+    netuid: NetUid,
+    children: Vec<(u64, T::AccountId)>,
+) -> DispatchResultWithPostInfo {
+    Self::do_schedule_children(origin, hotkey, netuid, children)?;
+    Ok(().into())
+}
 ```
 
 Delegates to [`do_schedule_children`](/code/pallets/subtensor/src/staking/set_children.rs#L475).