Skip to content

fix(transaction-fee): make swap_hotkey(v2) fees payable in alpha #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
loom-agent wants to merge 3 commits into from
Closed

fix(transaction-fee): make swap_hotkey(v2) fees payable in alpha #2891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6ccfa3
fix(transaction-fee): make swap_hotkey(v2) fees payable in alpha
loom-agent Jul 13, 2026
e4b243f
test(subtensor): allow deprecated storage in last-tx-block migration …
loom-agent Jul 13, 2026
c783de7
Merge branch 'main' into fix/alpha-fee-swap-hotkey
unarbos Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions pallets/transaction-fee/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,33 @@ impl<F, OU> SubtensorTxFeeHandler<F, OU> {
origin_netuid,
..
}) => alpha_vec.push((hotkey.clone(), *origin_netuid)),
Some(SubtensorCall::swap_hotkey {
hotkey,
new_hotkey: _,
netuid,
}) => match netuid {
Some(netuid) => alpha_vec.push((hotkey.clone(), *netuid)),
None => {
let netuids = OU::get_all_netuids_for_coldkey_and_hotkey(who, hotkey);
netuids
.into_iter()
.for_each(|netuid| alpha_vec.push((hotkey.clone(), netuid)));
}
},
Some(SubtensorCall::swap_hotkey_v2 {
hotkey,
new_hotkey: _,
netuid,
keep_stake: _,
}) => match netuid {
Some(netuid) => alpha_vec.push((hotkey.clone(), *netuid)),
None => {
let netuids = OU::get_all_netuids_for_coldkey_and_hotkey(who, hotkey);
netuids
.into_iter()
.for_each(|netuid| alpha_vec.push((hotkey.clone(), netuid)));
}
},
Some(SubtensorCall::recycle_alpha {
hotkey,
amount: _,
Expand Down
66 changes: 66 additions & 0 deletions pallets/transaction-fee/src/tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,72 @@ fn test_rejects_multi_subnet_alpha_fee_deduction() {
assert_eq!(alpha_before_1, alpha_after_1);
});
}
// cargo test --package subtensor-transaction-fee --lib -- tests::test_swap_hotkey_fees_alpha --exact --show-output
#[test]
fn test_swap_hotkey_fees_alpha() {
new_test_ext().execute_with(|| {
let sn = setup_subnets(2, 2);
let stake_amount = TAO;
setup_stake(
sn.subnets[0].netuid,
&sn.coldkey,
&sn.hotkeys[0],
stake_amount,
);
setup_stake(
sn.subnets[1].netuid,
&sn.coldkey,
&sn.hotkeys[0],
stake_amount,
);

// swap_hotkey and swap_hotkey_v2 move alpha stake off the origin hotkey,
// so their fees must be eligible to be paid in alpha on every subnet that
// hotkey has stake. Before the fix `fees_in_alpha` returned an empty vec
// for these calls, forcing a TAO fee (and rejecting alpha-only callers).

// netuid = None -> every subnet the origin hotkey has stake on (2 here).
let call_all = RuntimeCall::SubtensorModule(pallet_subtensor::Call::swap_hotkey {
hotkey: sn.hotkeys[0],
new_hotkey: sn.hotkeys[1],
netuid: None,
});
let alpha_vec_all =
SubtensorTxFeeHandler::<Balances, TransactionFeeHandler<Test>>::fees_in_alpha::<Test>(
&sn.coldkey,
&call_all,
);
assert_eq!(alpha_vec_all.len(), 2);

@github-actions github-actions Bot Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] All-subnet case still cannot pay in alpha

This assertion produces two fee sources, but can_withdraw_in_alpha explicitly returns false whenever alpha_vec.len() != 1. Consequently, the exact two-subnet scenario constructed here is still rejected with InvalidTransaction::Payment, contrary to the PR’s stated fix. Test the actual fee-validation/withdrawal path with no TAO balance, and either select a single eligible subnet deterministically or narrow the advertised behavior to single-subnet swaps.


// netuid = Some(single) -> only that subnet.
let call_one = RuntimeCall::SubtensorModule(pallet_subtensor::Call::swap_hotkey {
hotkey: sn.hotkeys[0],
new_hotkey: sn.hotkeys[1],
netuid: Some(sn.subnets[0].netuid),
});
let alpha_vec_one =
SubtensorTxFeeHandler::<Balances, TransactionFeeHandler<Test>>::fees_in_alpha::<Test>(
&sn.coldkey,
&call_one,
);
assert_eq!(alpha_vec_one.len(), 1);

// swap_hotkey_v2 moves the same alpha and must be eligible too.
let call_v2 = RuntimeCall::SubtensorModule(pallet_subtensor::Call::swap_hotkey_v2 {
hotkey: sn.hotkeys[0],
new_hotkey: sn.hotkeys[1],
netuid: None,
keep_stake: false,
});
let alpha_vec_v2 =
SubtensorTxFeeHandler::<Balances, TransactionFeeHandler<Test>>::fees_in_alpha::<Test>(
&sn.coldkey,
&call_v2,
);
assert_eq!(alpha_vec_v2.len(), 2);
});
}

// cargo test --package subtensor-transaction-fee --lib -- tests::test_remove_stake_fees_alpha --exact --show-output
#[test]
fn test_remove_stake_fees_alpha() {
Expand Down
Loading