Fix build warnings#2913
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH scrutiny due to a <30-day-old account with one public repo; mitigated by repository write permission, matching author/committer, and no known Gittensor association. Branch targets main. The 13-line vendor-only diff is mechanical: it makes elided lifetimes explicit, removes an unused constant, and removes a redundant clone from a copyable public-key value. No dependencies, runtime behavior, security configuration, or trusted AI-review files are changed. FindingsNo findings. ConclusionNo malicious behavior or security vulnerability was found in the static review. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 UNKNOWN gittensor association; newer contributor with repository write access and one prior merged PR, so the small vendored-code cleanup received strict static scrutiny. PR body was empty/trivial; the Auditor has auto-filled it. Please review. This is a minimal warning cleanup across vendored Frontier and w3f-bls code. The explicit anonymous lifetimes preserve existing borrowing behavior, the unused constant removal is inert, and replacing FindingsNo findings. ConclusionThe changes are narrowly scoped, behavior-preserving warning fixes with no substantive correctness or runtime-safety concerns. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Motivation
Rust builds currently report warnings in the vendored Frontier and w3f-bls sources. This PR removes those warnings without changing runtime behavior.
Changes
Files of interest:
vendor/frontier/client/rpc/src/eth/pending.rsvendor/frontier/precompiles/src/evm/handle.rsvendor/frontier/precompiles/src/testing/execution.rsvendor/w3f-bls/src/double_pop.rsvendor/w3f-bls/src/verifiers.rsBehavioral impact
None expected. These changes only make inferred lifetimes explicit and remove unused or redundant operations.
Migration and spec version
No storage migration is required, and no runtime spec-version bump is needed.
Testing
The changes were reviewed statically as warning-only, behavior-preserving cleanup.