Skip to content

Fix build warnings#2913

Open
UnArbosFour wants to merge 1 commit into
stagingfrom
fix/cleanup-warnings
Open

Fix build warnings#2913
UnArbosFour wants to merge 1 commit into
stagingfrom
fix/cleanup-warnings

Conversation

@UnArbosFour

@UnArbosFour UnArbosFour commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Motivation

Rust builds currently report warnings in the vendored Frontier and w3f-bls sources. This PR removes those warnings without changing runtime behavior.

Changes

  • Add explicit anonymous lifetimes to borrowed Frontier RPC and precompile return types.
  • Remove an unused w3f-bls context constant.
  • Avoid an unnecessary clone of a copyable w3f-bls public-key value.

Files of interest:

  • vendor/frontier/client/rpc/src/eth/pending.rs
  • vendor/frontier/precompiles/src/evm/handle.rs
  • vendor/frontier/precompiles/src/testing/execution.rs
  • vendor/w3f-bls/src/double_pop.rs
  • vendor/w3f-bls/src/verifiers.rs

Behavioral impact

None expected. These changes only make inferred lifetimes explicit and remove unused or redundant operations.

Migration and spec version

No storage migration is required, and no runtime spec-version bump is needed.

Testing

The changes were reviewed statically as warning-only, behavior-preserving cleanup.

@UnArbosFour UnArbosFour added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jul 15, 2026
@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subtensor Ready Ready Preview, Comment Jul 15, 2026 8:59am

Request Review

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

VERY HIGH scrutiny due to a <30-day-old account with one public repo; mitigated by repository write permission, matching author/committer, and no known Gittensor association. Branch targets main.

The 13-line vendor-only diff is mechanical: it makes elided lifetimes explicit, removes an unused constant, and removes a redundant clone from a copyable public-key value. No dependencies, runtime behavior, security configuration, or trusted AI-review files are changed.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability was found in the static review.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

UNKNOWN gittensor association; newer contributor with repository write access and one prior merged PR, so the small vendored-code cleanup received strict static scrutiny.

PR body was empty/trivial; the Auditor has auto-filled it. Please review.

This is a minimal warning cleanup across vendored Frontier and w3f-bls code. The explicit anonymous lifetimes preserve existing borrowing behavior, the unused constant removal is inert, and replacing clone() on the copyable public-key value does not alter verification semantics. No runtime code, storage, weights, dependencies, or migrations change; no spec-version bump is required. No duplicate or overlapping PR was identified.

Findings

No findings.

Conclusion

The changes are narrowly scoped, behavior-preserving warning fixes with no substantive correctness or runtime-safety concerns.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@UnArbosFour UnArbosFour changed the base branch from main to staging July 15, 2026 14:20
@github-actions github-actions Bot mentioned this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant