Fix hardcoded leasing weights#2915
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH account-age/activity scrutiny, mitigated by repository write access; no Gittensor association found; fix/leasing-weights → staging. Static review found the generated weight calls match the benchmark parameter semantics: registration uses the crowdloan’s total contributor count, while termination restores the excluded beneficiary with a saturating increment. No dependency, privileged-origin, workflow, or supply-chain changes are present. FindingsNo findings. ConclusionThe change removes stale underweight formulas and correctly reports the newer generated post-dispatch weights. No malicious behavior or security vulnerability was found. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 UNKNOWN Gittensor association; very new contributor with limited history, mitigated by repository write access. The generated weight functions match the benchmark parameter semantics: registration uses the crowdloan’s total contributor count, while termination adds the beneficiary excluded from No spec-version bump is required for the FindingsNo findings. ConclusionThe change correctly replaces stale weight formulas with generated weights and validates the reported post-dispatch values. It is ready to merge. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
Landed in staging via #2927 (cherry-picked, one squashed commit per PR). |
SubnetLeasingWeightInfocontains copied benchmark constants from 2025, while generated weights were refreshed in July 2026. For termination, the helper reports roughly 56.6m + 0.913mk, versus the generated 100.6m + 1.594mk. That likely causes excessive post-dispatch fee refunds.This PR replaces the local formulas with generated
WeightInfocalls, adds post-dispatch weight tests, and deletes the duplicate table.