Json convert #406
Merged
Json convert #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenNneji
force-pushed
the
jsonConvert
branch
from
3e696af to
9a71e20
Compare
DrPaulSharp
reviewed
Aug 5, 2025
Collaborator
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
This all looks good, I have a few hopefully minor points to consider.
…dual class vartable is easier. Storing progress for now....
… project - not sure why....
…ing to projectClass
…olums gets deleted)
StephenNneji
force-pushed
the
jsonConvert
branch
from
9a71e20 to
cdbf978
Compare
DrPaulSharp
approved these changes
Aug 7, 2025
StephenNneji
pushed a commit
that referenced
this pull request
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions for saving and loading Jsons for projectClass, controls and results.
The functions are in the /utils/misc folder.
There is a simple test in /jsonDevs' called jsonTests, which makes sure the svaled and loaded versions are the same and work as expected.
(Apologies but I don't understand how to integrate the tests into the testing framework!)