Fix snow error#194
Open
jCabala wants to merge 12 commits into
Open
Conversation
scaraven
requested changes
May 14, 2026
Comment on lines
+129
to
+134
| thread::sleep(Duration::from_millis(1500)); | ||
|
|
||
| // Spawn a duplicate of the first participant (fresh Noise context, same session) | ||
| let dupe_args = participant_args(&participants[0], server_url, group_pk_hex, &session_id); | ||
| let mut dupe = run_cli_spawn_piped(binary, cwd, &dupe_args); | ||
| thread::sleep(Duration::from_secs(2)); |
Member
There was a problem hiding this comment.
The two sleep commands might be a bit flaky. The test will be more robust if we do something similiar as in get_session_id() where you poll until you see certain output that you expect + fail on a timeout. You can match on stderr messages such as Sending SigningPackage or Waiting for participants to send their SignatureShares.
However, that does mean that the test will rely on stderr output for robustness, that's not super futureproof so I'm 50/50 on whether it's worth implementing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session ID handling
--session(-S) required for theparticipantsubcommand - participants must now always specify a session ID explicitlymina-frost-client sessions --group <group>lists active sessions with their IDsDuplicate participant handling
Tests
tests/duplicate_participant.rs- an integration test that spawns a duplicate participant mid-session and asserts the coordinator warns, does not crash, and produces a valid signaturesign_with_binaryhelper which was broken by the now-required--sessionflag; addedget_session_idhelper that polls the server for the active session UUID