[RIP-20] 12 Words and a number support for android app#87
Open
ben-abraham wants to merge 5 commits intoRavenProject:masterfrom
Open
[RIP-20] 12 Words and a number support for android app#87ben-abraham wants to merge 5 commits intoRavenProject:masterfrom
ben-abraham wants to merge 5 commits intoRavenProject:masterfrom
Conversation
Added BR Shared pref for storing known seed timestamp. When starting a fresh sync we will accept checkpoints up to the timestamp of the BR Shared pref Added checkpoints at 4 block-week intervals (roughly one block-month), up to the latest time. Also removed a few duplicate checkpoints. Currently no UI for reading out or inputting the code yet.
…, as well as display an FAQ dialog explaining what it does. Added proper UI validation around the value, erroring if negative or outside of the current week-value UI is properly fed into BRPrefs, and is functioning correctly. The largest piece remaining is the displayed value on the output of the fast restore key when creating a new wallet.
…restore key, as well as details on it's purpose. Adjusted verbiage slightly to instruct leaving the field empty if unknown. Fixed possible type issues in fast-restore key helper functions.
…ear-immediate sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #86 [Add RIP-20 Support to Android RVN Wallet]
Raven Core blog post: RIP-20 proposal
I decided on the name "Fast-restore key" for the field, but I am open to changing this. I'll happily update all the verbiage and references if there is another name to use.
Implemented:
knownSeedTime_RVNBRPeerManager.cto allow more places that new syncs will be able to use.The primary functionality is fully working and useable currently. A brand new wallet is synced in under 10 minutes now (in emulator.) The time can be brought down more by having additional checkpoints in the header file, perhaps even automatically updated. There are plenty of ways this could be achieved, but for the moment I went with monthly checkpoints.
Remaining:
Additional thoughts:
Raven Address: RYW4MmiT2jDdZPa499VQiPANZdStxGt8y5
Screenshots:
