-
Notifications
You must be signed in to change notification settings - Fork 24
CREST Adapter #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
calvinp0
wants to merge
67
commits into
main
Choose a base branch
from
crest_adapter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CREST Adapter #807
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
c7e9c0a
Adds angstrom to bohr conversion factor
calvinp0 c727294
Adds CREST settings and installation for transition state search
calvinp0 e265cdd
Adds CREST TS search adapter
calvinp0 432e594
Adds CREST documentation
calvinp0 5d1612d
Normalizes TSGuess method sources
calvinp0 8891252
Adds CREST to available TS search methods
calvinp0 146a145
Adds CREST as TS adapter option
calvinp0 abd9201
Adds function to reorder XYZ strings.
calvinp0 87f3c51
Fixes restart tests for parallel execution
calvinp0 0baa098
Added the job pipe sub-module
alongd cab5b28
Updated the pipe submission script
alongd f8d102b
Added pipe_settings
alongd 24ac9db
Added the pipe_worker script
alongd 9e7cab6
Removed the previous pipe implementation
alongd 96c70ce
Implement pipe into Scheduler
alongd 1b2a9cb
Docs: pipe mode
alongd 1b20560
Merge branch 'main' into crest_adapter
calvinp0 a18828f
Merge branch 'pipe' into crest_adapter
calvinp0 42b0798
Fixes
calvinp0 63207c4
Adjustments
calvinp0 5c7dc77
Update
calvinp0 c46792c
Thread back to Scheduler after completion of TS pipeline
calvinp0 9840d33
Race to condition
calvinp0 15503d9
Better reporting
calvinp0 de8e67b
Added troubleshooting of failed indiv. pipe jobs
calvinp0 6ae8b8c
Further updates
calvinp0 00b5e2f
Updates
calvinp0 a9ac64f
Scratch fix
calvinp0 c26d5b2
Path sep
calvinp0 7986864
Handle existing pipe directories on fresh start
calvinp0 b995e05
Handle existing pipe directories on fresh start
calvinp0 5e67ea4
Add FAILED_ESS task state and document pipe task lifecycle
calvinp0 3be97bf
Fix premature 'all conformer jobs terminated' when others still running
calvinp0 c5b659f
Move pipe directories from runs/ into calcs/ with auto-indexing
calvinp0 a985a3c
Document pipe directory structure in advanced.rst
calvinp0 b3b54ec
Write task_summary.txt on pipe run completion
calvinp0 1267ea5
Write task_summary.txt on pipe run completion
calvinp0 52c558d
Add tests for pipe directory restructure, ESS error classification, a…
calvinp0 9d86a9a
Add tests for pipe directory restructure, ESS error classification, a…
calvinp0 86d8f12
Fix premature check_all_done when species has active pipe run
calvinp0 456bca8
Fix unused variable in pipe_state_test
calvinp0 41f0454
Fix worker tests: mock _parse_ess_error for mockter adapter
calvinp0 b948f75
Fix species tests for method_sources in TSGuess
calvinp0 7a4c61a
Merge remote-tracking branch 'origin/main' into crest_adapter_pipe
calvinp0 02cddd7
Improve Arkane AEC and BAC validation and logging
calvinp0 21f1880
Resolve AEC and BAC keys independently for Arkane corrections
calvinp0 3f21891
Enhance Arkane level of theory identification and AEC validation logging
calvinp0 591b492
Support independent AEC and BAC keys in the QM corrections script
calvinp0 7425633
Merge branch 'arkane_m_fix' into crest_adapter_pipe
calvinp0 254a29f
Improve Arkane AEC and BAC validation and logging
calvinp0 78fc445
Resolve AEC and BAC keys independently for Arkane corrections
calvinp0 7261198
Enhance Arkane level of theory identification and AEC validation logging
calvinp0 938c49b
Support independent AEC and BAC keys in the QM corrections script
calvinp0 801498b
Merge branch 'arkane_m_fix' into crest_adapter_pipe
calvinp0 1e71353
Fix stranding species when conformer troubleshooting is exhausted
calvinp0 94aa7d5
Refine pipe resubmission logic to prevent redundant scheduler jobs
calvinp0 f3bc145
Handle monoatomic species for DLPNO methods
calvinp0 dd796ed
Handle monoatomic species for DLPNO methods in Orca
calvinp0 abeabd2
Handle DLPNO methods for monoatomic species
calvinp0 a4cf6fb
Fix switch_ts to reset state & clean up IRC when switching TS guesses
calvinp0 994d6c4
Pass server job IDs to the pipe coordinator during polling
calvinp0 701f986
Handle task initialization failures in the pipe worker
calvinp0 58b8fd5
Handle terminated scheduler jobs during pipe reconciliation
calvinp0 86b8044
Detect terminated scheduler jobs during pipe polling
calvinp0 d7258d3
Added CANCELLED
calvinp0 a7e9f63
Merge branch 'main' into crest_adapter_pipe
calvinp0 5646c5b
Merge branch 'pipe_job_cancel' into crest_adapter_pipe
calvinp0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| cdef double pi, Na, kB, R, h, hbar, c, e, m_e, m_p, m_n, amu, a0, bohr_to_angstrom, E_h, F, E_h_kJmol | ||
| cdef double pi, Na, kB, R, h, hbar, c, e, m_e, m_p, m_n, amu, a0, E_h, F, E_h_kJmol, bohr_to_angstrom, angstrom_to_bohr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| import arc.job.adapters.ts.autotst_ts | ||
| import arc.job.adapters.ts.crest | ||
| import arc.job.adapters.ts.gcn_ts | ||
| import arc.job.adapters.ts.heuristics | ||
| import arc.job.adapters.ts.kinbot_ts | ||
| import arc.job.adapters.ts.seed_hub | ||
| import arc.job.adapters.ts.xtb_gsm | ||
| import arc.job.adapters.ts.orca_neb |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we add install-crest into install-all as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above