Conversation
|
Roel has very kindly released a binary of |
|
To-fix:
|
|
Unrelated note, but the entryEdit functionality seems kind of suspicious and maybe we shouldn't allow users to actually use those (I don't think anyone is, and they don't even work on the main site.) We may want to just remove it. |
|
Some Solute (tdep, soluteML) functionalities may be present in SolProp and thereby maybe we don't need chemprop_solvation. |
- update descriptastorus old pin (was causing issues/outdated) - update solprop mix to new repo - add cantera pin because of weird glitch?
|
This will almost be ready. It looks like the new environment is working fine now. |
|
This PR is now ready for review. If you want to toy around with it, it's active on the dev site: https://rmg.mit.edu:888/ There's a quirk to the installation process. Sometimes a pip version of Please let me know if you have any questions or want to chat about any of this |
|
I've confirmed that SoluteML is returning unphysical values in the current development version. This is the same issue described in fhvermei/chemprop_solvation#3, caused by changes in newer What issues did keeping the older pin of |
|
Old versions of descriptastorus use This renders the website inoperable. So we need to use a more recent version of descriptastorus. Maybe 2.5.1 will work? I'll give it a try... |
|
Another option could be to not use This would require some changes to the code though. |
We observed non-physical SoluteML values due presumably to a new version of descripastorus. However, old versions use the old name of "gilbrat" instead of "gibrat", a name that was removed in scipy 1.11.0. And at the same time RMG requires scipy >=1.9.0 for MILP functionality.
|
Testing other versions of
I see we can get descripastorus=2.5.0 by pinning the scipy version (which isn't a tenable long-term solution, but the env can at least be solved.) Unfortunately, it looks like this still results in non-physical answers. Even trying |
SoluteML package seems busted. We might need to rely on the newly retrained version instead.
The new soluteML version code can process a batch of inputs, so the code is rewritten to accommodate this.
Gsolv model was called instead of Hsolv
Reverts "WIP: replace SoluteML with solprop_ml_mix" This reverts commit 063fbdf.
180147b to
0db9a9e
Compare
1893db7 to
b3e55de
Compare
|
@jonwzheng I've completed moving |
After updating to microservices (many thanks to you Jackson!), there was a remaining mismatch in data types that caused an error. This commit fixes it, so the user can use SoluteML now.
|
Just fixed a bug in |
|
Dev website looks like it's working well with the new changes! |
JacksonBurns
left a comment
There was a problem hiding this comment.
From what (little) I know about web dev, this looks good. The proof is in the pudding, and the pudding runs smoothly and more securely than ever before.
Going to talk on one last commit to update a missing link in the microservice documentation, then you can merge this at your pleasure @jonwzheng. Thanks again for sticking around to help push this over the finish line
|
I also approve of the microservice solprop changes. |
This PR seeks to update
RMG-websiteto be compatible with Python 3.9 so that it can leverage the newest version ofRMG-Pyand other packages.To do this, a number of things need to be updated simultaneously (avoid dependency hell):
solpropusing the py3.9 compatible version, or turn it into an API service so that it can be queried separately. Updatingsolpropwould for now be the most straightforward option. Although an API service would be the best solution technologically, it would take the most technical load to learn and implement sustainably. Another way is to call it via a subprocess in its own separatecondaordockerenvironment, which would also require some rewriting of the backend. Key concern is whether it's fast enough. In the future, probably we want to move toward one of the two latter options, especially if we want to deploy more ML models on the site.There's also an opportunity to make the
condaenvironment leaner (which should make solving for it more straightforward in general).edit 23 March 2026 by @JacksonBurns:
@jonwzheng and I have collaboratively made efforts to move
solpropinto a container and use it as a microservice. This allows us to remain on the old Python 3.7 version and appreciably simplify the RMG-website environment.