Attempting to Fix the juliacall Overhaul on RMG#268
Merged
JacksonBurns merged 39 commits intoReactionMechanismGenerator:for_rmgfrom May 29, 2025
Merged
Attempting to Fix the juliacall Overhaul on RMG#268JacksonBurns merged 39 commits intoReactionMechanismGenerator:for_rmgfrom
juliacall Overhaul on RMG#268JacksonBurns merged 39 commits intoReactionMechanismGenerator:for_rmgfrom
Conversation
Contributor
Author
|
The related RMG-Py PR is here: ReactionMechanismGenerator/RMG-Py#2749 |
JacksonBurns
force-pushed
the
fix_installation
branch
from
a84641c to
3f1a878
Compare
…that are only available locally
this causes an error when the conda backend is set to Null (i.e. julia is disallowed from installing conda packages), see: ReactionMechanismGenerator/RMG-Py#2749 (comment)
JacksonBurns
force-pushed
the
fix_installation
branch
from
3f1a878 to
65959be
Compare
jonwzheng
reviewed
May 23, 2025
jonwzheng
left a comment
jonwzheng
left a comment
There was a problem hiding this comment.
looks good. Do you know what's going on with the CI?
| prectmp = ilu(W, τ=tau) | ||
| preccache = Ref(prectmp) | ||
|
|
||
| if sparsity > 0.8 |
There was a problem hiding this comment.
why were these needed in this update?
Contributor
Author
Contributor
Author
It's failing on all PRs right now: https://github.com/ReactionMechanismGenerator/ReactionMechanismSimulator.jl/actions/runs/14458289456/job/40545991323?pr=269 |
Contributor
Author
|
@jonwzheng I've tried changing the CI s.t. RMS will figure out Conda on its own (as it should) rather than us trying to set up conda for it in the CI - will have to see if it works. |
rwest
approved these changes
May 28, 2025
Member
rwest
left a comment
rwest
left a comment
There was a problem hiding this comment.
I'm not a Julia expert, but the commits look reasonable, and it seems to work.
JacksonBurns
merged commit 43018b1
into
ReactionMechanismGenerator:for_rmg
0 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch from which I am making this PR contains some outdated edits from @hwpang which were intended to make the change from
pyjuliatojuliacallpossible. Since there are now edits on this branch of RMS (which is used during the RMG installation process) I am opening this PR to check which (if any) are still required, and to just see what the actual changes are.