Skip to content

4.x Cleanup: isEmpty, general intellij cleanups - #8181

Closed
akarnokd wants to merge 6 commits into
ReactiveX:4.xfrom
akarnokd:4xGeneralCleanup2
Closed

4.x Cleanup: isEmpty, general intellij cleanups#8181
akarnokd wants to merge 6 commits into
ReactiveX:4.xfrom
akarnokd:4xGeneralCleanup2

Conversation

@akarnokd

Copy link
Copy Markdown
Member
  • Remove @SafeVarargs from varargs with non-generic element types.
  • Remove unnecessary semicolons.
  • Use switch expression.
  • Remove inferrable generic type declarations.
  • Javadocs cleanup

@akarnokd akarnokd added this to the 4.0 milestone Jun 25, 2026
@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.499 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/core/CompletionStageDisposable.java: 4.610
src/main/java/io/reactivex/rxjava4/core/Notification.java: 4.610
src/main/java/io/reactivex/rxjava4/disposables/ActionDisposable.java: 4.944
src/main/java/io/reactivex/rxjava4/disposables/AutoCloseableDisposable.java: 4.952
src/main/java/io/reactivex/rxjava4/disposables/CompositeDisposable.java: 4.285
src/main/java/io/reactivex/rxjava4/disposables/FutureDisposable.java: 4.933
src/main/java/io/reactivex/rxjava4/disposables/ReferenceDisposable.java: 4.865
src/main/java/io/reactivex/rxjava4/disposables/RunnableDisposable.java: 4.981
src/main/java/io/reactivex/rxjava4/disposables/SubscriptionDisposable.java: 4.996
src/main/java/io/reactivex/rxjava4/exceptions/CompositeException.java: 4.386
src/main/java/io/reactivex/rxjava4/exceptions/MissingBackpressureException.java: 4.883
src/main/java/io/reactivex/rxjava4/exceptions/OnErrorNotImplementedException.java: 4.876
src/main/java/io/reactivex/rxjava4/exceptions/ProtocolViolationException.java: 4.944
src/main/java/io/reactivex/rxjava4/exceptions/QueueOverflowException.java: 4.912
src/main/java/io/reactivex/rxjava4/exceptions/UndeliverableException.java: 4.960
src/main/java/io/reactivex/rxjava4/internal/disposables/ArrayCompositeDisposable.java: 4.480
src/main/java/io/reactivex/rxjava4/internal/disposables/CancellableDisposable.java: 4.807
src/main/java/io/reactivex/rxjava4/internal/disposables/ListCompositeDisposable.java: 4.090
src/main/java/io/reactivex/rxjava4/internal/disposables/SequentialDisposable.java: 4.695
src/main/java/io/reactivex/rxjava4/internal/jdk8/FlowableCollectWithCollector.java: 4.523

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.499 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/core/CompletionStageDisposable.java: 4.610
src/main/java/io/reactivex/rxjava4/core/Notification.java: 4.610
src/main/java/io/reactivex/rxjava4/disposables/ActionDisposable.java: 4.944
src/main/java/io/reactivex/rxjava4/disposables/AutoCloseableDisposable.java: 4.952
src/main/java/io/reactivex/rxjava4/disposables/CompositeDisposable.java: 4.285
src/main/java/io/reactivex/rxjava4/disposables/FutureDisposable.java: 4.933
src/main/java/io/reactivex/rxjava4/disposables/ReferenceDisposable.java: 4.865
src/main/java/io/reactivex/rxjava4/disposables/RunnableDisposable.java: 4.981
src/main/java/io/reactivex/rxjava4/disposables/SubscriptionDisposable.java: 4.996
src/main/java/io/reactivex/rxjava4/exceptions/CompositeException.java: 4.386
src/main/java/io/reactivex/rxjava4/exceptions/MissingBackpressureException.java: 4.883
src/main/java/io/reactivex/rxjava4/exceptions/OnErrorNotImplementedException.java: 4.876
src/main/java/io/reactivex/rxjava4/exceptions/ProtocolViolationException.java: 4.944
src/main/java/io/reactivex/rxjava4/exceptions/QueueOverflowException.java: 4.912
src/main/java/io/reactivex/rxjava4/exceptions/UndeliverableException.java: 4.960
src/main/java/io/reactivex/rxjava4/internal/disposables/ArrayCompositeDisposable.java: 4.480
src/main/java/io/reactivex/rxjava4/internal/disposables/CancellableDisposable.java: 4.807
src/main/java/io/reactivex/rxjava4/internal/disposables/ListCompositeDisposable.java: 4.090
src/main/java/io/reactivex/rxjava4/internal/disposables/SequentialDisposable.java: 4.695
src/main/java/io/reactivex/rxjava4/internal/jdk8/FlowableCollectWithCollector.java: 4.523

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 5.083 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

.github/workflows/gradle_branch.yml: 5.083
.github/workflows/gradle_pr.yml: 4.933
.github/workflows/gradle_preview_jdks.yml: 5.129
.github/workflows/gradle_release.yml: 5.211
.github/workflows/gradle_snapshot.yml: 5.059

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 5.083 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

.github/workflows/gradle_branch.yml: 5.083
.github/workflows/gradle_pr.yml: 4.933
.github/workflows/gradle_preview_jdks.yml: 5.129
.github/workflows/gradle_release.yml: 5.211
.github/workflows/gradle_snapshot.yml: 5.059

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 5.083 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

.github/workflows/gradle_branch.yml: 5.083
.github/workflows/gradle_pr.yml: 4.933
.github/workflows/gradle_preview_jdks.yml: 5.129
.github/workflows/gradle_release.yml: 5.211
.github/workflows/gradle_snapshot.yml: 5.059

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@akarnokd

Copy link
Copy Markdown
Member Author

Something broke the unit tests on CI and no idea what. I'll redo the cleanups part by part.

@akarnokd akarnokd closed this Jun 26, 2026
@akarnokd
akarnokd deleted the 4xGeneralCleanup2 branch June 30, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant