4.x cleanup: spinwait, grammar, minor syntax simplifications - #8185
Closed
akarnokd wants to merge 2 commits into
Closed
4.x cleanup: spinwait, grammar, minor syntax simplifications#8185akarnokd wants to merge 2 commits into
akarnokd wants to merge 2 commits into
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.636 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (89.47%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8185 +/- ##
============================================
+ Coverage 98.32% 98.34% +0.01%
Complexity 6936 6936
============================================
Files 785 785
Lines 48998 48987 -11
Branches 6599 6598 -1
============================================
- Hits 48179 48174 -5
+ Misses 622 620 -2
+ Partials 197 193 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.636 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Member
Author
|
Another weird crash on CI. Probably that spinwait introduced a runaway allocation somewhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thread.onSpinWait()<p>to correct styling.signalled->signaledcancelled->canceled