Skip to content

4.x: Fix Streamable.fromStream not closing the Stream - #8267

Merged
akarnokd merged 2 commits into
ReactiveX:4.xfrom
akarnokd:4xStreamableFromStreamCloseFix
Aug 5, 2026
Merged

4.x: Fix Streamable.fromStream not closing the Stream#8267
akarnokd merged 2 commits into
ReactiveX:4.xfrom
akarnokd:4xStreamableFromStreamCloseFix

Conversation

@akarnokd

@akarnokd akarnokd commented Aug 5, 2026

Copy link
Copy Markdown
Member

Forgot to close the Stream once the operator was done with it, like all the other variations.

We got a report for it as a security vulnerability, hammer and nail, hence the quick fix.

The report was some kind of tool or AI. By https://github.com/August829

@akarnokd akarnokd added this to the 4.0 milestone Aug 5, 2026
@akarnokd
akarnokd merged commit d36352f into ReactiveX:4.x Aug 5, 2026
6 checks passed
@akarnokd
akarnokd deleted the 4xStreamableFromStreamCloseFix branch August 5, 2026 08:58
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (3895db1) to head (28fdf5a).
⚠️ Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8267      +/-   ##
============================================
+ Coverage     98.60%   98.62%   +0.01%     
- Complexity     7145     7147       +2     
============================================
  Files           824      824              
  Lines         50768    50782      +14     
  Branches       6905     6906       +1     
============================================
+ Hits          50061    50082      +21     
+ Misses          482      478       -4     
+ Partials        225      222       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant