Fix Combo, Misses, and NotesSpawned#27
Open
ChrisJAllan wants to merge 1 commit intoReadieFur:masterfrom
Open
Conversation
Contributor
|
Can confirm the issues in #26, as well as full combo does not set to false when a bad cut happend. Also misses are not incremented when that happend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
While testing, I noticed bad cuts weren't breaking combo, adding misses, or adding notes spawned, so fixed those. Bomb hits are not counted under misses, which is consistent with the documentation and other mods, but the LiveData.ColorType is now set correctly before returning.
Side note:
my compiler really doesn't likeFound it, C# 11 preview featureDefaultValueTAttributebecause CS0698? How do you get around this? I did the annoying thing and made each use it's own class, but that's a pain.