Skip to content

fix: PHP 8.4 nullable exception constructors #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
colinbird wants to merge 1 commit into from
Closed

fix: PHP 8.4 nullable exception constructors #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/php84-exception-nullable.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rebilly/client-php": patch
---

Fix PHP 8.4 deprecations on exception constructors by marking `$previous` as explicitly nullable.
2 changes: 1 addition & 1 deletion sdk-generator/templates/static/src/Exception/DataValidationException.php.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ final class DataValidationException extends HttpException
{
private array $validationErrors = [];

public function __construct(array $content = [], $message = '', $code = 0, Exception $previous = null)
public function __construct(array $content = [], $message = '', $code = 0, ?Exception $previous = null)
{
if (isset($content['invalidFields']) && is_array($content['invalidFields'])) {
$this->validationErrors = $content['invalidFields'];
Expand Down
2 changes: 1 addition & 1 deletion src/Exception/DataValidationException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ final class DataValidationException extends HttpException
{
private array $validationErrors = [];

public function __construct(array $content = [], $message = '', $code = 0, Exception $previous = null)
public function __construct(array $content = [], $message = '', $code = 0, ?Exception $previous = null)
{
if (isset($content['invalidFields']) && is_array($content['invalidFields'])) {
$this->validationErrors = $content['invalidFields'];
Expand Down
2 changes: 1 addition & 1 deletion src/Exception/GoneException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

final class GoneException extends ClientException
{
public function __construct($message = '', $code = 0, Exception $previous = null)
public function __construct($message = '', $code = 0, ?Exception $previous = null)
{
parent::__construct(410, $message, $code, $previous);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Exception/HttpException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class HttpException extends Exception
{
private int $statusCode;

public function __construct($status, $message = '', $code = 0, Exception $previous = null)
public function __construct($status, $message = '', $code = 0, ?Exception $previous = null)
{
$this->statusCode = (int) $status;
parent::__construct($message, $code, $previous);
Comment thread
colinbird marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion src/Exception/NotFoundException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

final class NotFoundException extends ClientException
{
public function __construct($message = '', $code = 0, Exception $previous = null)
public function __construct($message = '', $code = 0, ?Exception $previous = null)
{
parent::__construct(404, $message, $code, $previous);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Exception/TooManyRequestsException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ final class TooManyRequestsException extends ClientException

private int $rateLimit;

public function __construct($retryAfter, $rateLimit = 0, $message = '', $code = 0, Exception $previous = null)
public function __construct($retryAfter, $rateLimit = 0, $message = '', $code = 0, ?Exception $previous = null)
{
$this->retryAfter = $retryAfter;
$this->rateLimit = (int) $rateLimit;
Expand Down
Loading