Add Keyboard method to open the Keyboard screen

[scmcgowen]

The Keyboard screen will forward mouse inputs scaled to the grid of the 2d canvas.

[Ale32bit]

To clarify, this merge request implements a keyboard module method to open the keyboard "GUI" as if the player right clicked the module itself, right?

[scmcgowen]

Yes, that is what it does, though interestingly right clicking the module no longer opens the NI's keyboard (unrelated to my PR, its something I noticed when testing)

[Ale32bit]

Is there any safe guard to prevent the player from being stuck in a loop that keeps opening the keyboard?

[scmcgowen]

Currently, the best way would be to set plethora:keyboard:captureInput's base cost higher in the plethora config, however I am open to any suggestions on other ways to do that

[dimaguy]

Is there any meaningful usecase for this? It feels prone to exploitation, especially if misconfigured by a server owner

[scmcgowen]

The primary use case I envision is getting key and mouse input at the normal rate a terminal does on a keybind, such as for a NI chat system or a graphical menu using the Overlay Glasses.
The Keyboard alone doesn't give you mouse input, and also gives key presses at a faster rate, which is good for keybinds such as laser firing, but is not great for typing text into the overlay glasses.

[scmcgowen]

I am open to suggestions on how to mitigate exploitability, however, and will consider any option to reduce the impact while not eliminating the envisioned primary use case

[dimaguy]

I have a suggestion, what if instead of getting regular mouse output, which is only useful for 2d canvases, you threw a raycast and got an object on the 3d canvas it would return 3d coordinates and but if it hits a 2d overlay first it would return 2d coordinates.
Maybe the keyboard could have an advanced version with a different recipe for mouse input capability?

[scmcgowen]

That sounds more complicated to implement, plus I'd have to get the 3d canvas to see what's on it to do a raycast. Seems interesting though, but also doesn't seem to prevent the problem of effectively softlocking yourself by calling it in a loop.

[dimaguy]

I'm thinking that client side there could be an SOS option to disable the method taking effect on the client, on modmenu or something

[scmcgowen]

[Ale32bit]

Also add a cooldown for the method after its GUI is closed, like a second or two.
Make it unable to open if any other GUI is open, including the pause menu.

[scmcgowen]

I'll try to implement that tomorrow