fix: ensure that all endpoints properly respect excludeMined param #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented functionality for the `/krist/transactions` and `/addresses/<address>/transactions` endpoint while also making sure that the total value returned filtered out mined transactions in all endpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented functionality for the
/transactionsand/addresses/<address>/transactionsendpoint while also making sure that the total value returned respected the value in all endpoints (/transactions/latest. Tested on my machine and it worked fine across all three endpoints.Had to implement a couple of functions to avoid redefining traits. Also switched a couple of query parameters from
AddressTransactionQuerytoPaginationParamssince the former is for theincludeMinedquery param on lookup endpoints, not the correctexcludeMinedparam used elsewhere. I had minor merge issues with #11 but was easy to resolve.Should hopefully fix #14 and #15.