[Infra] virtual machine template STP

[RoniKishner]

STP Metadata

VEP issue: https://github.com/kubevirt/enhancements/blob/main/veps/sig-compute/76-vmtemplates/vmtemplate-proposal.md

What this PR does

Add STP for new virtual machine template CRD

Special notes for your reviewer

Summary by CodeRabbit

• Documentation
  • Added a comprehensive test plan for VirtualMachine templating: end-to-end feature overview, user-visible workflows (template process/convert/create), testing scope (functional, security, compatibility, regression, upgrade), prioritized test tiers (P0/P1/P2), admission-time validation expectations, environment assumptions, risks, traceability matrix, and GA entry/approval criteria.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f98e7cc4-a6e7-4ea4-b1ca-9ec29f52b610

📥 Commits

Reviewing files that changed from the base of the PR and between ff38850 and a3b2a0e.

📒 Files selected for processing (1)

• stps/sig-infra/virtual-machine-template.md

✅ Files skipped from review due to trivial changes (1)

• stps/sig-infra/virtual-machine-template.md

---

Walkthrough

Adds a new Software Test Plan defining testing scope and strategies for KubeVirt native in-cluster VirtualMachine templating, covering server-side processing (/process, /create), virtctl workflows, parameter substitution, RBAC, integration points, testing goals, environment assumptions, and GA criteria.

Changes

Cohort / File(s)	Summary
Test Plan Documentation stps/sig-infra/virtual-machine-template.md	New comprehensive test plan for in-cluster VirtualMachineTemplate and VirtualMachineTemplateRequest features, including end-to-end flows, P0/P1/P2 test scenarios, validation expectations, RBAC and cross-namespace behavior, environment prerequisites, risks, traceability matrix, and GA sign-off checklist.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title '[Infra] virtual machine template STP' directly and clearly summarizes the main change: adding a Software Test Plan document for the Virtual Machine Template feature.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-virtualization-qe-bot-2]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest all - Run all available tests

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)

📊 Review Process

Approvers and Reviewers

Approvers:

• RoniKishner
• geetikakay

Reviewers:

• RoniKishner
• geetikakay

Available Labels

• hold
• verified
• wip
• lgtm
• approve

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is automatically removed on each new commit
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@stps/sig-infra/virtual-machine-template.md`:
- Line 120: Update the table row containing the "Compute Resources" entry so the
environment requirement uses the proper noun capitalization: change the cell
text "Sufficient for windows VM and snapshot/clone operations." to "Sufficient
for Windows VM and snapshot/clone operations." Locate the row that starts with
"**Compute Resources**" in virtual-machine-template.md and replace the lowercase
"windows" with "Windows" to correct the casing.
- Around line 74-84: Ensure priority tiers are consistent between the "Testing
Goals" list and the traceability matrix by picking a single priority for each
scenario and updating both sections to match; specifically reconcile entries
such as "Verify virt-operator deploys virt-template", "Verify cross-namespace:
template in namespace A, VM creation in namespace B", and other duplicated
scenarios (e.g., virtctl template convert/create, golden-image template flow) so
each scenario appears once with the agreed priority in both the Testing Goals
and the traceability matrix; update the priority tags (P0/P1/P2) for the
duplicated items and run a diff to confirm no mismatches remain.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 63370dec-8dd4-40e9-b1da-760b84ee2256

📥 Commits

Reviewing files that changed from the base of the PR and between de81e3d and ff38850.

📒 Files selected for processing (1)

• stps/sig-infra/virtual-machine-template.md

[dominikholler]

Where would be the best place to define a Windows test case?
I would consider a restoring a VM from a template which depends on persistent data from vTPM and maybe even from efi as an interesting test case.