WIP: [4.20] Storage: replace artifactory with DataSource in restricted namespace cloning tests#3892#4286
Open
kshvaika wants to merge 2 commits intoRedHatQE:cnv-4.20from
Conversation
… cloning tests (RedHatQE#3892) This PR replaces the use of the artifactory Cirros image with the DataSource Fedora in tests/storage/restricted_namespace_cloning https://issues.redhat.com/browse/CNV-79291 The PR was assisted by Cursor AI <!-- full-ticket-url needs to be provided. This would add a link to the pull request to the jira and close it when the pull request is merged If the task is not tracked by a Jira ticket, just write "NONE". --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Tests** * Updated test infrastructure for improved namespace cloning and multi-storage scenarios. * Standardized VM and data volume defaults to Fedora images/sizes for consistent VM testing. * Added permission-driven test setup to validate restricted VM access and get-only permissions. * Cleaned up test parameters and wiring for clearer, more maintainable storage and cloning tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-3
requested review from
duyanyan,
josemacassan,
jpeimer and
kgoldbla
kshvaika
commented
Mar 26, 2026
| dv_size = source_spec_dict.get("resources", {}).get("requests", {}).get("storage") or source_dict.get( | ||
| "status", {} | ||
| ).get("restoreSize") | ||
| # dv_size = get_dv_size_from_datasource(data_source=fedora_data_source_scope_module) |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4286 published |
Contributor
|
/wip |
openshift-virtualization-qe-bot-3
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##### Short description:
Manual cherry-pick: #3892
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket: