Tests net localnet ipam se cnv 4.20#4330
Merged
rnetser merged 2 commits intoRedHatQE:cnv-4.20from Apr 5, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
Contributor
Author
|
/wip |
azhivovk
force-pushed
the
tests-net-localnet-ipam-se-cnv-4.20
branch
from
c6db248 to
6691bfa
Compare
azhivovk
changed the title
openshift-virtualization-qe-bot-3
changed the title
Contributor
Author
|
Change: rebase |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
azhivovk
force-pushed
the
tests-net-localnet-ipam-se-cnv-4.20
branch
from
e7d8836 to
745bcc9
Compare
Contributor
Author
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
azhivovk
force-pushed
the
tests-net-localnet-ipam-se-cnv-4.20
branch
from
745bcc9 to
51cb792
Compare
Contributor
Author
|
Change: Edit commit message |
Contributor
|
Clean rebase detected — no code changes compared to previous head ( |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/verified PSI cluster with cnv-4.20: |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 230 🏁 Script executed: Length of output: 16636 🏁 Script executed: Length of output: 379 🏁 Script executed: Length of output: 1735 🧠 Learnings used |
Introduce LOCALNET_IPAM_LOGICAL_NETWORK constant and localnet_ipam_vm helper for creating VMs attached to a localnet IPAM-backed network without static cloud-init IP configuration. Signed-off-by: Asia Khromov <azhivovk@redhat.com>
Contributor
Author
|
Change: Edit commit message |
Contributor
Author
|
/verified |
|
Clean rebase detected — no code changes compared to previous head ( |
…dHatQE#4288) Cover the scenario where a secondary network is plugged to the VM with IPAM, causing the bridge binding to pass the IP configuration to the Guest using the internal DHCPv4 server. This is an exception to OCP-V support, as IPAM on secondary networks is not formally supported. The scenario is covered for a support exception. This is the first part of the support exception coverage, wiring only a single secondary network interface to the VM. A follow up PR should also wire a non IPAM interface, which is defined using cloud-init, to show it can co-exist with the main one. As this is not the critical part which required coverage, it is left for a follow up. Signed-off-by: Asia Khromov <azhivovk@redhat.com>
Contributor
Author
|
Change: Edit commit messages |
|
Clean rebase detected — no code changes compared to previous head ( |
Contributor
Author
|
/verified |
EdDev
approved these changes
Apr 5, 2026
Contributor
EdDev
left a comment
EdDev
left a comment
There was a problem hiding this comment.
Thanks.
I think the last commit should have the original authors as well, but I won't hold on it.
/approve
Collaborator
|
/approve |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.20 published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick into cnv-4.20 of #4288
Includes changes of adding custom ipam VM as refactoring the existing localnet VM requires fixing too many conflicts.