Skip to content

[4.20] Upgrade: skip virt-launcher update check when image unchanged#4334

Open
dshchedr wants to merge 1 commit intoRedHatQE:cnv-4.20from
dshchedr:skip-virt-launcher-update-check-cnv-4.20
Open

[4.20] Upgrade: skip virt-launcher update check when image unchanged#4334
dshchedr wants to merge 1 commit intoRedHatQE:cnv-4.20from
dshchedr:skip-virt-launcher-update-check-cnv-4.20

Conversation

@dshchedr
Copy link
Copy Markdown
Collaborator

@dshchedr dshchedr commented Apr 1, 2026

Manual cherry-pick for #4269

The test_vmi_pod_image_updates_after_upgrade_optin test was failing on Z
release upgrades where virt-launcher image doesn't change. Skip automatic
workload update migration verification when virt-launcher image is unchanged.

Changes:

  • Add virt_launcher_from_csv_before_upgrade fixture to capture
    virt-launcher image before upgrade
  • Add csv_after_upgrade fixture to get target CSV
  • Compare virt-launcher images before/after upgrade in unupdated_vmi_pods_names
  • Skip automatic migration check with warning when image unchanged
  • Simplify validate_vms_pod_updated to accept expected image directly

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: de2cec99-c349-4b76-b552-0b29bf2b7b6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-virtualization-qe-bot
Copy link
Copy Markdown

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • dshchedr
  • vsibirsk

Reviewers:

  • SamAlber
  • SiboWang1997
  • akri3i
  • dshchedr
  • hmeir
  • jerry7z
  • kbidarkar
  • rlobillo
  • vsibirsk
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

Manual cherry-pick for RedHatQE#4269

The test_vmi_pod_image_updates_after_upgrade_optin test was failing on Z
release upgrades where virt-launcher image doesn't change. Skip automatic
workload update migration verification when virt-launcher image is unchanged.

Changes:
- Add virt_launcher_from_csv_before_upgrade fixture to capture
  virt-launcher image before upgrade
- Add csv_after_upgrade fixture to get target CSV
- Compare virt-launcher images before/after upgrade in unupdated_vmi_pods_names
- Skip automatic migration check with warning when image unchanged
- Simplify validate_vms_pod_updated to accept expected image directly

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

(cherry picked from commit 1e89a7f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants