[Storage] remove artifactory usage in test_cdi_config.py#4342
Merged
dshchedr merged 12 commits intoRedHatQE:mainfrom Apr 13, 2026
Merged
[Storage] remove artifactory usage in test_cdi_config.py#4342dshchedr merged 12 commits intoRedHatQE:mainfrom
dshchedr merged 12 commits intoRedHatQE:mainfrom
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new CDI config test suite under Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
requested review from
Ahmad-Hafe,
dalia-frank,
josemacassan and
jpeimer
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4342 published |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/storage/cdi_config/test_cdi_config.py`:
- Line 213: create_vm_from_dv is a `@contextmanager` and must be invoked with a
with-statement to ensure its cleanup path runs; replace the bare call
create_vm_from_dv(client=unprivileged_client, dv=dv) with a with
create_vm_from_dv(client=unprivileged_client, dv=dv) as vm_dv: block (use vm_dv
inside or include a pass if unused) following the pattern used in the existing
helper (e.g., the with usage in the utils test helper).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b75577f8-87d9-4b9e-b82a-55a9fae0a8d7
📒 Files selected for processing (4)
tests/storage/cdi_config/__init__.pytests/storage/cdi_config/conftest.pytests/storage/cdi_config/test_cdi_config.pytests/storage/cdi_config/utils.py
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/storage/cdi_config/test_cdi_config.py`:
- Around line 195-205: get_dv_size_from_datasource may return None and that None
is passed into create_dv(size=...), so add a fail-fast guard immediately after
calling get_dv_size_from_datasource: check the returned value and raise an
AssertionError or ValueError (with a clear message referencing the data source)
if size is None before entering the with(...) block that calls create_dv; this
uses the existing symbols get_dv_size_from_datasource and create_dv and ensures
deterministic failures instead of propagating a None into create_dv.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5a7f2e68-77e6-4cf9-ac4e-5387fb6de5c2
📒 Files selected for processing (1)
tests/storage/cdi_config/test_cdi_config.py
Contributor
Author
|
/wip |
Signed-off-by: Emanuele Prella <eprella@redhat.com>
for more information, see https://pre-commit.ci Signed-off-by: Emanuele Prella <eprella@redhat.com>
Signed-off-by: Emanuele Prella <eprella@redhat.com>
Signed-off-by: Emanuele Prella <eprella@redhat.com>
Signed-off-by: Emanuele Prella <eprella@redhat.com>
Signed-off-by: Emanuele Prella <eprella@redhat.com>
Signed-off-by: Emanuele Prella <eprella@redhat.com>
…for propagation checks Signed-off-by: Emanuele Prella <eprella@redhat.com>
…move unused utils module Signed-off-by: Emanuele Prella <eprella@redhat.com>
|
Clean rebase detected — no code changes compared to previous head ( |
dshchedr
approved these changes
Apr 9, 2026
Collaborator
|
@ema-aka-young please re-trigger the smoke tests job |
Contributor
Author
|
/retest all |
Contributor
|
@rnetser this PR should not affect smoke, why is it triggered? |
Contributor
Author
|
/verified cancel |
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 1897 🧠 Learnings used |
|
Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-4342. |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published |
Contributor
Author
|
/cherry-pick cnv-4.21 cnv-4.20 cnv-4.19 |
|
Manual cherry-pick is needed |
|
Manual cherry-pick is needed |
|
Manual cherry-pick is needed |
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
This PR replaces the use of the artifactory images with the DataSource Fedora in tests/storage/test_cdi_config.py and moves it to its dedicated folder.
More details:
https://redhat.atlassian.net/browse/CNV-83362
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Assisted by Claude Code
jira-ticket:
Summary by CodeRabbit