Rf build test 2#1067
Merged
Merged
Conversation
NadiaSergeeva
requested changes
Jun 3, 2026
| .clickItemNewJob() | ||
| .setProjectName(PROJECT_NAME) | ||
| .selectFreestyleProjectAndClickOk() | ||
| .selectFreeStyleProject() |
Collaborator
There was a problem hiding this comment.
здесь надо оставлять .selectFreestyleProjectAndClickOk()
Сергей про это говорил, должен быть такой двойной метод
Collaborator
There was a problem hiding this comment.
Вижу, что метод разделился все же на 2 .selectFreeStyleProject() и .clickOkButton()
| .clickOkButton() | ||
| .goHomePage() | ||
| .clickOnProject(PROJECT_NAME, new FreestyleProjectPage(getDriver())) | ||
| .getSideMenu() |
Collaborator
There was a problem hiding this comment.
а зачем ты удалила getSideMenu?
это же компонент sideMenu, который я писала и рассказывала вам)
| .goHomePage() | ||
| .clickOnProject(PROJECT_NAME, new FreestyleProjectPage(getDriver())) | ||
| .getSideMenu() | ||
| .clickConfigure(new FreestyleProjectConfigPage(getDriver())) |
Collaborator
There was a problem hiding this comment.
и здесь тоже.. ты, наверно, так конфликт решала, но это как то неправильно...
| .clickOnChildProject(FOLDER_CHILD, new NestedFolderPage(getDriver())) | ||
| .clickNewItem() | ||
| .setProjectName(FREESTYLE_NESTED) | ||
| .selectFreestyleProjectAndClickOk() |
Collaborator
There was a problem hiding this comment.
этот метод нужно оставить. он должен быть один, который выбирает проект и кликает ок
babadza
approved these changes
Jun 4, 2026
Natalyakba
approved these changes
Jun 4, 2026
NadiaSergeeva
approved these changes
Jun 4, 2026
|
|
||
| public FreestyleProjectConfigPage clickBuildStep(By locator) { | ||
| getDriver().findElement(locator).click(); | ||
|
|
Collaborator
There was a problem hiding this comment.
тут можно без пустой строки,когда одна строчка кода
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.