Add test_folder_buttons#879
Merged
Merged
Conversation
petr2o1o
reviewed
May 30, 2026
| @pytest.mark.dependency(depends=['test_folder_apply_button']) | ||
| def test_folder_save_button(browser): | ||
| save_result = (HomePage(browser) | ||
| .click_project_name(FOLDER_NAME, 'folder') |
Collaborator
There was a problem hiding this comment.
вы определяете переменную save_result, но не используете ее
petr2o1o
approved these changes
May 30, 2026
| assert project_names_list[0] == DISPLAY_NAME | ||
|
|
||
|
|
||
| @pytest.mark.dependency(depends=['test_create_folder']) |
Collaborator
There was a problem hiding this comment.
В данном модуле нет теста test_create_folder. Видимо это опечатка. Поэтому во время CI оба теста, предложенных к коммиту, просто скипнулись...
tests/test_folder_configuration.py::test_folder_apply_button SKIPPED
tests/test_folder_configuration.py::test_folder_save_button SKIPPED
Space-researcher
approved these changes
Jun 3, 2026
| .click_project_name(FOLDER_NAME, 'folder') | ||
| .click_project_configure('folder') | ||
| .set_display_name("Display_name") | ||
| .click_apply() |
Collaborator
There was a problem hiding this comment.
CI не проходит: AttributeError: 'FolderConfigPage' object has no attribute 'click_apply'
| assert description_content == FOLDER_DESCRIPTION | ||
|
|
||
| @pytest.mark.dependency(depends=['test_create_folder']) | ||
| def test_folder_apply_button(browser): |
Collaborator
There was a problem hiding this comment.
Зачем добавлять одинаковые тесты одновременно в test_folder.py и test_folder_configuration.py? Пусть они будут в каком-то одном модуле.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.