Open
Conversation
saamerm
commented
Dec 23, 2021
saamerm
commented
- Updated README
|
I think the info should be included in this repos actual readme, not a link to an article. Very helpful though! |
Closed
|
Nice blog post but linking to your own blog in a different library's readme seems poor taste. |
Author
|
@Hackmodford & @svaldetero those are fair arguments from your point of view. My point of view was that there's just one line of README added so it's much cleaner and easier to merge than overtaking the readme with 400 words and a video related to just App Icon usage. As you'll notice in the article and the video, it's a very delicate process and it's easy to get stuff wrong. So do we really want to bombard this GitHub repo with non-stop app icon issues? |
@saamerm Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.