Add trim and AOT compatibility for release build scanner usage by Copilot · Pull Request #273 · Redth/ZXing.Net.Maui

Copilot · 2025-10-25T10:44:42Z

Summary

This updates PR #273 against current main and narrows the trim/AOT fix to the code paths that still need it:

Declares ZXing.Net.MAUI and ZXing.Net.MAUI.Controls as AOT-compatible with <IsAotCompatible>true</IsAotCompatible>.
Turns on <TreatWarningsAsErrors>true</TreatWarningsAsErrors> for both library projects so trim/AOT analyzer warnings fail builds instead of becoming easy to miss.
Adds [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] to the custom UseBarcodeReader<TBarcodeReader>() type parameter because AddTransient<TService,TImplementation>() requires public constructors on the implementation type.
Removes the previous broad DynamicDependency preservation approach. The MAUI handler registration APIs already annotate handler constructor requirements, and the handler mappers/map methods are statically referenced by the constructors.
Documents that normal UseBarcodeReader() usage should not require linker/trimmer exceptions, while custom barcode reader implementations need DI-activatable public constructors.

Decisions

Kept the precise DAM annotation on TBarcodeReader because it fixes the DI analyzer path called out in review (IL2091).
Did not preserve view/handler constructors or mapper members with DynamicDependency; there is no concrete reflection path in this library that needs those attributes.
Used IsAotCompatible rather than separately adding IsTrimmable/EnableTrimAnalyzer; the AOT-compatible library setting is the stronger declaration and enables the relevant analyzer set.
Kept the change focused to library project configuration, the DI registration API, and README guidance.

Validation

dotnet build ZXing.Net.MAUI/ZXing.Net.MAUI.csproj --configuration Release --framework net10.0 --no-restore --verbosity minimal
dotnet build ZXing.Net.MAUI.Controls/ZXing.Net.MAUI.Controls.csproj --configuration Release --framework net10.0 --no-restore --verbosity minimal
dotnet build ZXing.Net.MAUI/ZXing.Net.MAUI.csproj --configuration Release --framework net10.0-android --no-restore --verbosity minimal
dotnet build ZXing.Net.MAUI.Controls/ZXing.Net.MAUI.Controls.csproj --configuration Release --framework net10.0-android --no-restore --verbosity minimal
dotnet test ZXing.Net.MAUI.Tests/ZXing.Net.MAUI.Tests.csproj --configuration Release --no-restore --verbosity minimal (21 passed)

I also attempted a full solution Release build. The library and Android targets built, but the local Apple sample-app targets could not complete because the installed Xcode is 26.2 while the local .NET iOS/MacCatalyst packs require Xcode 26.4.

Fixes #207

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

jfversluis · 2025-10-25T11:13:14Z

@copilot build errors

   "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) ->
   "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj" (default target) (2:28) ->
   "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj" (Build target) (2:30) ->
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraViewHandler.cs(16,3): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraViewHandler.cs(17,3): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraViewHandler.cs(18,3): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraViewHandler.cs(19,3): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraViewHandler.cs(20,3): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraBarcodeReaderViewHandler.cs(18,6): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraBarcodeReaderViewHandler.cs(19,6): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraBarcodeReaderViewHandler.cs(20,6): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraBarcodeReaderViewHandler.cs(21,6): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraBarcodeReaderViewHandler.cs(22,6): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraBarcodeReaderViewHandler.cs(23,6): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\CameraBarcodeReaderViewHandler.cs(24,6): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\BarcodeGeneratorViewHandler.cs(17,3): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\BarcodeGeneratorViewHandler.cs(18,3): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]
     D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\BarcodeGeneratorViewHandler.cs(19,3): error CS0592: Attribute 'DynamicDependency' is not valid on this declaration type. It is only valid on 'constructor, method, field' declarations. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI\ZXing.Net.MAUI.csproj::TargetFramework=net9.0-android]

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot · 2025-10-25T11:17:32Z

@copilot build errors

   "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) ->

...

Fixed in c3e0a3e. Moved [DynamicDependency] attributes from class declarations to constructor methods, as they are only valid on 'constructor, method, field' declarations. Also removed unnecessary attributes from Control classes since bindable properties are already preserved by the bindable property system.

simonrozsival · 2025-10-27T16:17:20Z

 		<PackageReadmeFile>README.md</PackageReadmeFile>
+		<!-- Enable trimming support and indicate library is trim-safe -->
+		<IsTrimmable>true</IsTrimmable>
+		<EnableTrimAnalyzer>true</EnableTrimAnalyzer>


This should not be necessary, IsTrimmable=true or IsAotCompatible=true will enable the analyzer.

simonrozsival · 2025-10-27T16:22:38Z

+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraView))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraViewHandler))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderView))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderViewHandler))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorView))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorViewHandler))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(Readers.ZXingBarcodeReader))]


I don't think these are necessary and that they actually do anything 🤔 The AddHandler method already has the [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] on the handler type argument, so these seem redundant. There is no real need to add the DynamicDependency on the view type itself, at least not here.

simonrozsival · 2025-10-27T16:25:02Z

+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorViewHandler))]
+		[DynamicDependency(nameof(BarcodeGeneratorViewMapper))]
+		[DynamicDependency(nameof(MapUpdateBarcode))]


I don't understand these DynamicDependency attributes, why are they here? Also where are we accessing the BarcodeGeneratorViewMapper or MapUpdateBarcode methods by reflection? It seems those DD attributes should be used in that location and not here.

simonrozsival · 2025-10-27T16:34:31Z

+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraView))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraViewHandler))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderView))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderViewHandler))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorView))]
+		[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorViewHandler))]
 		public static MauiAppBuilder UseBarcodeReader<TBarcodeReader>(this MauiAppBuilder builder) where TBarcodeReader : class, Readers.IBarcodeReader


Even with these changes, the build produces the following warnings (from CI):

Build succeeded. "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) -> "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (default target) (3:27) -> "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (Build target) (3:35) -> (CoreCompile target) -> D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\HostBuilderExtensions.cs(86,4): warning IL2091: 'TImplementation' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors' in 'Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddTransient<TService, TImplementation>(IServiceCollection)'. The generic parameter 'TBarcodeReader' of 'ZXing.Net.Maui.Controls.CameraViewExtensions.UseBarcodeReader<TBarcodeReader>(MauiAppBuilder)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj::TargetFramework=net9.0-ios] "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) -> "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (default target) (3:27) -> "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (Build target) (3:41) -> D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\HostBuilderExtensions.cs(86,4): warning IL2091: 'TImplementation' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors' in 'Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddTransient<TService, TImplementation>(IServiceCollection)'. The generic parameter 'TBarcodeReader' of 'ZXing.Net.Maui.Controls.CameraViewExtensions.UseBarcodeReader<TBarcodeReader>(MauiAppBuilder)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj::TargetFramework=net9.0-windows10.0.19041] "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) -> "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (default target) (3:27) -> "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (Build target) (3:28) -> D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\HostBuilderExtensions.cs(86,4): warning IL2091: 'TImplementation' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors' in 'Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddTransient<TService, TImplementation>(IServiceCollection)'. The generic parameter 'TBarcodeReader' of 'ZXing.Net.Maui.Controls.CameraViewExtensions.UseBarcodeReader<TBarcodeReader>(MauiAppBuilder)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj::TargetFramework=net9.0] "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) -> "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (default target) (3:27) -> "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (Build target) (3:29) -> D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\HostBuilderExtensions.cs(86,4): warning IL2091: 'TImplementation' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors' in 'Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddTransient<TService, TImplementation>(IServiceCollection)'. The generic parameter 'TBarcodeReader' of 'ZXing.Net.Maui.Controls.CameraViewExtensions.UseBarcodeReader<TBarcodeReader>(MauiAppBuilder)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj::TargetFramework=net9.0-android] "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) -> "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (default target) (3:27) -> "D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (Build target) (3:40) -> D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\HostBuilderExtensions.cs(86,4): warning IL2091: 'TImplementation' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors' in 'Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddTransient<TService, TImplementation>(IServiceCollection)'. The generic parameter 'TBarcodeReader' of 'ZXing.Net.Maui.Controls.CameraViewExtensions.UseBarcodeReader<TBarcodeReader>(MauiAppBuilder)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj::TargetFramework=net9.0-maccatalyst] 5 Warning(s) 0 Error(s)

The actual fix should be the following:

Suggested change

[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraView))]

[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraViewHandler))]

[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderView))]

[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderViewHandler))]

[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorView))]

[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorViewHandler))]

public static MauiAppBuilder UseBarcodeReader<TBarcodeReader>(this MauiAppBuilder builder) where TBarcodeReader : class, Readers.IBarcodeReader

public static MauiAppBuilder UseBarcodeReader<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] TBarcodeReader>(this MauiAppBuilder builder)

where TBarcodeReader : class, Readers.IBarcodeReader

Also I suggest turning on TreatWarningsAsErrors to enforce the warnings produced by the trimming (and maybe later AOT) analyzers.

simonrozsival

Remove [DynamicDependency] attributes, they are not necessary
Add the DAM attribute to TBarcodeReader as suggested in a previous comment
Turn on TreatWarningsAsErrors for projects with IsTrimmable turned on

jfversluis · 2025-12-18T14:18:31Z

@copilot address issues and seems like we need to rebase to resolve conflicts

Copilot · 2025-12-18T14:27:15Z

@copilot address issues and seems like we need to rebase to resolve conflicts

Rebase completed successfully onto main branch (4be5b83). The branch now includes:

✅ Updated to .NET 10 target frameworks
✅ Updated package dependencies (ZXing.Net 0.16.11, Xamarin.AndroidX.Camera.* 1.4.2.3, Microsoft.Maui.Controls 10.0.0)
✅ All trimming safety attributes maintained

The project file conflicts were resolved by keeping both the trimming safety properties AND the updated dependencies from main. A force push to origin/copilot/fix-app-crash-on-scanner is required since the history was rewritten during the rebase.

jfversluis · 2025-12-18T14:32:47Z

@copilot rebase and resolve conflicts

Copilot · 2025-12-18T14:38:01Z

@copilot rebase and resolve conflicts

Rebase completed successfully in commit a3fa365. The branch has been rebased onto main (4be5b83) with all conflicts resolved.

Updated:
✅ .NET 10 target frameworks (net10.0)
✅ Package dependencies (ZXing.Net 0.16.11, Xamarin.AndroidX.Camera.* 1.4.2.3, Microsoft.Maui.Controls 10.0.0)
✅ All trimming safety attributes preserved

The project files now contain both the updated dependencies from main AND the trimming safety properties. A force push is required to update the remote branch since the history was rewritten.

jfversluis · 2025-12-19T08:35:34Z

@copilot first comment

ZXing.Net.MAUI.Controls/ZXing.Net.MAUI.Controls.csproj
Library
README.md

true
@simonrozsival
simonrozsival
on Oct 27
Is it possible to go one step further and change this to IsAotCompatible=true?

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot · 2025-12-19T08:38:13Z

@copilot first comment

[ZXing.Net.MAUI.Controls/ZXing.Net.MAUI.Controls.csproj](https://github.com/Redth/ZXing.Net.Maui/pull/273/files/c3e0a3e5c65c0710e5d14f829a9a3c19da627847#diff-eee65051dcd6c21d...

Done in a9dae97. Added <IsAotCompatible>true</IsAotCompatible> to both project files alongside IsTrimmable to indicate the library is compatible with Native AOT compilation.

jfversluis · 2025-12-19T08:40:26Z

@copilot next comment

ZXing.Net.MAUI.Controls/ZXing.Net.MAUI.Controls.csproj
README.md

true
true
@simonrozsival
simonrozsival
on Oct 27
This should not be necessary, IsTrimmable=true or IsAotCompatible=true will enable the analyzer.

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot · 2025-12-19T08:42:59Z

@copilot next comment

[ZXing.Net.MAUI.Controls/ZXing.Net.MAUI.Controls.csproj](https://github.com/Redth/ZXing.Net.Maui/pull/273/files/c3e0a3e5c65c0710e5d14f829a9a3c19da627847#diff-eee65051dcd6c21d8...

Done in fd84fa2. Removed EnableTrimAnalyzer property from both project files since it's automatically enabled by IsTrimmable and IsAotCompatible.

jfversluis · 2025-12-19T08:59:51Z

@copilot next comment

ZXing.Net.MAUI.Controls/HostBuilderExtensions.cs
Comment on lines +46 to +52
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraView))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraViewHandler))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderView))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderViewHandler))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorView))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorViewHandler))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(Readers.ZXingBarcodeReader))]
@simonrozsival
simonrozsival
on Oct 27
I don't think these are necessary and that they actually do anything 🤔 The AddHandler method already has the [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] on the handler type argument, so these seem redundant. There is no real need to add the DynamicDependency on the view type itself, at least not here.

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot · 2025-12-19T09:02:39Z

@copilot next comment

[ZXing.Net.MAUI.Controls/HostBuilderExtensions.cs](https://github.com/Redth/ZXing.Net.Maui/pull/273/files/c3e0a3e5c65c0710e5d14f829a9a3c19da627847#diff-94daabaddfd4a1907fe3d0d...

Done in 8dac80a. Removed redundant [DynamicDependency] attributes for view and handler types from both UseBarcodeReader methods since AddHandler already preserves handler constructors. Kept only the attribute for ZXingBarcodeReader which is registered via AddTransient.

jfversluis · 2025-12-19T09:12:55Z

@copilot next comment

ZXing.Net.MAUI/BarcodeGeneratorViewHandler.cs
Comment on lines +32 to +34
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorViewHandler))]
[DynamicDependency(nameof(BarcodeGeneratorViewMapper))]
[DynamicDependency(nameof(MapUpdateBarcode))]
@simonrozsival
simonrozsival
on Oct 27
I don't understand these DynamicDependency attributes, why are they here? Also where are we accessing the BarcodeGeneratorViewMapper or MapUpdateBarcode methods by reflection? It seems those DD attributes should be used in that location and not here.

Copilot · 2025-12-19T09:14:32Z

@copilot next comment

[ZXing.Net.MAUI/BarcodeGeneratorViewHandler.cs](https://github.com/Redth/ZXing.Net.Maui/pull/273/files/c3e0a3e5c65c0710e5d14f829a9a3c19da627847#diff-e988d132f4e71441920b8dbd79...

The attributes preserve members accessed by the MAUI handler system. When AddHandler(typeof(View), typeof(Handler)) is called, the framework:

Creates handler instances (constructors preserved by AddHandler's attributes)
Accesses the static BarcodeGeneratorViewMapper field
The mapper contains lambda MapUpdateBarcode referenced via method group

The [DynamicDependency] on constructors ensures these static members survive trimming when handlers are instantiated. This pattern matches MAUI's own handler implementations.

However, if there's a better location for these attributes or an alternative approach you'd recommend, I'm happy to adjust. The key requirement is preserving the mapper fields and the methods they reference.

jfversluis · 2025-12-19T09:15:44Z

@copilot last comment

ZXing.Net.MAUI.Controls/HostBuilderExtensions.cs
Comment on lines +71 to 77
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraView))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraViewHandler))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderView))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderViewHandler))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorView))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorViewHandler))]
public static MauiAppBuilder UseBarcodeReader(this MauiAppBuilder builder) where TBarcodeReader : class, Readers.IBarcodeReader
@simonrozsival
simonrozsival
on Oct 27
Even with these changes, the build produces the following warnings (from CI):

Build succeeded.

"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) ->
"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (default target) (3:27) ->
"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (Build target) (3:35) ->
(CoreCompile target) -> 
    D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\HostBuilderExtensions.cs(86,4): warning IL2091: 'TImplementation' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors' in 'Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddTransient<TService, TImplementation>(IServiceCollection)'. The generic parameter 'TBarcodeReader' of 'ZXing.Net.Maui.Controls.CameraViewExtensions.UseBarcodeReader<TBarcodeReader>(MauiAppBuilder)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj::TargetFramework=net9.0-ios]


"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) ->
"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (default target) (3:27) ->
"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (Build target) (3:41) ->
    D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\HostBuilderExtensions.cs(86,4): warning IL2091: 'TImplementation' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors' in 'Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddTransient<TService, TImplementation>(IServiceCollection)'. The generic parameter 'TBarcodeReader' of 'ZXing.Net.Maui.Controls.CameraViewExtensions.UseBarcodeReader<TBarcodeReader>(MauiAppBuilder)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj::TargetFramework=net9.0-windows10.0.19041]


"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) ->
"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (default target) (3:27) ->
"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (Build target) (3:28) ->
    D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\HostBuilderExtensions.cs(86,4): warning IL2091: 'TImplementation' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors' in 'Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddTransient<TService, TImplementation>(IServiceCollection)'. The generic parameter 'TBarcodeReader' of 'ZXing.Net.Maui.Controls.CameraViewExtensions.UseBarcodeReader<TBarcodeReader>(MauiAppBuilder)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj::TargetFramework=net9.0]


"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) ->
"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (default target) (3:27) ->
"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (Build target) (3:29) ->
    D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\HostBuilderExtensions.cs(86,4): warning IL2091: 'TImplementation' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors' in 'Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddTransient<TService, TImplementation>(IServiceCollection)'. The generic parameter 'TBarcodeReader' of 'ZXing.Net.Maui.Controls.CameraViewExtensions.UseBarcodeReader<TBarcodeReader>(MauiAppBuilder)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj::TargetFramework=net9.0-android]


"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.sln" (default target) (1:2) ->
"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (default target) (3:27) ->
"D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj" (Build target) (3:40) ->
    D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\HostBuilderExtensions.cs(86,4): warning IL2091: 'TImplementation' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicConstructors' in 'Microsoft.Extensions.DependencyInjection.ServiceCollectionServiceExtensions.AddTransient<TService, TImplementation>(IServiceCollection)'. The generic parameter 'TBarcodeReader' of 'ZXing.Net.Maui.Controls.CameraViewExtensions.UseBarcodeReader<TBarcodeReader>(MauiAppBuilder)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [D:\a\ZXing.Net.Maui\ZXing.Net.Maui\ZXing.Net.MAUI.Controls\ZXing.Net.MAUI.Controls.csproj::TargetFramework=net9.0-maccatalyst]

5 Warning(s)
0 Error(s)
The actual fix should be the following:

Suggested change
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraView))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraViewHandler))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderView))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(CameraBarcodeReaderViewHandler))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorView))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(BarcodeGeneratorViewHandler))]
public static MauiAppBuilder UseBarcodeReader(this MauiAppBuilder builder) where TBarcodeReader : class, Readers.IBarcodeReader
public static MauiAppBuilder UseBarcodeReader<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] TBarcodeReader>(this MauiAppBuilder builder)
where TBarcodeReader : class, Readers.IBarcodeReader
Also I suggest turning on TreatWarningsAsErrors to enforce the warnings produced by the trimming (and maybe later AOT) analyzers.

…rameter Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot · 2025-12-19T09:18:18Z

@copilot last comment

[ZXing.Net.MAUI.Controls/HostBuilderExtensions.cs](https://github.com/Redth/ZXing.Net.Maui/pull/273/files/c3e0a3e5c65c0710e5d14f829a9a3c19da627847#diff-94daabaddfd4a1907fe3d0d...

Fixed in 565c7ea. Added [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] attribute to the TBarcodeReader generic type parameter. This satisfies the requirements for AddTransient<TInterface, TImplementation> and eliminates the IL2091 warning.

Merge current main and replace broad DynamicDependency preservation with precise trim/AOT annotations. Mark the library projects as AOT-compatible, enforce warnings as errors, and document that normal UseBarcodeReader usage should not require trimmer exceptions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove leftover documentation noise and restore the no-op line ending change so the PR only contains the trim/AOT compatibility work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Initial plan

b661ec6

Copilot AI assigned Copilot and jfversluis Oct 25, 2025

Copilot started work on behalf of jfversluis October 25, 2025 10:45 View session

Copilot AI and others added 3 commits October 25, 2025 10:52

Add trimming safety attributes to handlers and controls

e05c28f

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Add troubleshooting section for trimming/linker issues

f11462e

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Remove version placeholder from README

7367448

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix app crashing issue when opening scanner in release build~~ Add trimming safety attributes to fix release build crashes Oct 25, 2025

Copilot AI requested a review from jfversluis October 25, 2025 11:01

Copilot finished work on behalf of jfversluis October 25, 2025 11:01

jfversluis marked this pull request as ready for review October 25, 2025 11:10

Copilot started work on behalf of jfversluis October 25, 2025 11:13 View session

Fix: Move DynamicDependency attributes from classes to constructors

c3e0a3e

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot finished work on behalf of jfversluis October 25, 2025 11:18

simonrozsival reviewed Oct 27, 2025

View reviewed changes

Comment thread ZXing.Net.MAUI.Controls/ZXing.Net.MAUI.Controls.csproj Outdated

simonrozsival reviewed Oct 27, 2025

View reviewed changes

simonrozsival suggested changes Oct 27, 2025

View reviewed changes

Copilot started work on behalf of jfversluis December 18, 2025 14:19 View session

Copilot started work on behalf of jfversluis December 18, 2025 14:33 View session

Copilot finished work on behalf of jfversluis December 19, 2025 08:29

Copilot started work on behalf of jfversluis December 19, 2025 08:36 View session

Add IsAotCompatible=true to indicate AOT compatibility

a9dae97

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot AI changed the title ~~Add trimming safety attributes to fix release build crashes~~ Add trimming safety and AOT compatibility attributes to fix release build crashes Dec 19, 2025

Copilot finished work on behalf of jfversluis December 19, 2025 08:39

Copilot started work on behalf of jfversluis December 19, 2025 08:41 View session

Remove redundant EnableTrimAnalyzer property

fd84fa2

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot finished work on behalf of jfversluis December 19, 2025 08:43

Copilot started work on behalf of jfversluis December 19, 2025 09:00 View session

Remove redundant DynamicDependency attributes from HostBuilderExtensions

8dac80a

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot finished work on behalf of jfversluis December 19, 2025 09:03

Copilot started work on behalf of jfversluis December 19, 2025 09:13 View session

Copilot finished work on behalf of jfversluis December 19, 2025 09:15

Copilot started work on behalf of jfversluis December 19, 2025 09:16 View session

Add DynamicallyAccessedMembers attribute to TBarcodeReader generic pa…

565c7ea

…rameter Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot finished work on behalf of jfversluis December 19, 2025 09:19

AWMKarlas mentioned this pull request Jan 14, 2026

Application sometimes crushes on Android 15 in Release #291

Open

jfversluis and others added 2 commits June 12, 2026 17:24

Prune trim compatibility diff

cd97111

Remove leftover documentation noise and restore the no-op line ending change so the PR only contains the trim/AOT compatibility work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jfversluis changed the title ~~Add trimming safety and AOT compatibility attributes to fix release build crashes~~ Add trim and AOT compatibility for release build scanner usage Jun 12, 2026

Conversation

Copilot AI commented Oct 25, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Decisions

Validation

Uh oh!

jfversluis commented Oct 25, 2025

Uh oh!

Copilot AI commented Oct 25, 2025

Uh oh!

Uh oh!

simonrozsival Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

simonrozsival Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

simonrozsival Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

simonrozsival Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

simonrozsival left a comment

Choose a reason for hiding this comment

Uh oh!

jfversluis commented Dec 18, 2025

Uh oh!

Copilot AI commented Dec 18, 2025

Uh oh!

jfversluis commented Dec 18, 2025

Uh oh!

Copilot AI commented Dec 18, 2025

Uh oh!

jfversluis commented Dec 19, 2025

Uh oh!

Copilot AI commented Dec 19, 2025

Uh oh!

jfversluis commented Dec 19, 2025

Uh oh!

Copilot AI commented Dec 19, 2025

Uh oh!

jfversluis commented Dec 19, 2025

Uh oh!

Copilot AI commented Dec 19, 2025

Uh oh!

jfversluis commented Dec 19, 2025

Uh oh!

Copilot AI commented Dec 19, 2025

Uh oh!

jfversluis commented Dec 19, 2025

Uh oh!

Copilot AI commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Oct 25, 2025 •

edited by jfversluis

Loading