Fix Apple camera preview orientation#310
Merged
Merged
Conversation
Collaborator
Author
|
@bstadick since you authored the earlier orientation PR (#186), and @bhuvan94 since you opened the linked issue (#40): could you please test the artifacts from this PR if they help your situation? This is a fresh, focused iOS/MacCatalyst preview-orientation fix based on current |
Use the active window scene interface orientation for the iOS and MacCatalyst preview layer, falling back safely when scene orientation is unavailable. Trigger layout updates from an idempotent orientation observer and remove it during disconnect/dispose. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dd34363 to
cfe843d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UIWindowSceneinstead of relying onUIDevice.CurrentDevice.Orientationduring preview layout.EffectiveGeometry.InterfaceOrientationon iOS/MacCatalyst 26+ andUIWindowScene.InterfaceOrientationbelow that, with fallback to device orientation/last known/portrait when scene orientation is unavailable.LayoutSubviews()directly.Fixes #40.
Validation
dotnet restore ZXing.Net.MAUI/ZXing.Net.MAUI.csprojdotnet build ZXing.Net.MAUI/ZXing.Net.MAUI.csproj -f net10.0-ios -c Release --no-restoredotnet build ZXing.Net.MAUI/ZXing.Net.MAUI.csproj -f net10.0-maccatalyst -c Release --no-restore10.0.102selected from a session-localglobal.json.dotnet test ZXing.Net.MAUI.Tests/ZXing.Net.MAUI.Tests.csproj -f net10.0 -c ReleaseRemaining risk
Linked issues
Fixes #296.