Fix Android camera preview containment#314
Merged
Merged
Conversation
Configure CameraX PreviewView to use compatible rendering and clip its child surface to the view bounds so Android previews stay contained in constrained layouts such as grids, popups, and borders. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Thanks @viniciusverasdossantos, @MaximG1234, @Cav-jj, and @alberk8 for reporting the Android preview containment issues that helped narrow this down. This PR keeps the existing fill/crop preview behavior but changes the Android CameraX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PreviewViewto use compatible rendering so the preview surface behaves like a normal clipped view in constrained MAUI layouts.PreviewViewso grids, popups, and borders can contain the camera preview bounds.PreviewViewscale behavior; this does not switch toFitCenteror introduce letterboxing.Validation
dotnet build ZXing.Net.MAUI/ZXing.Net.MAUI.csproj -f net10.0-androiddotnet test ZXing.Net.MAUI.Tests/ZXing.Net.MAUI.Tests.csprojRisk
TextureView) instead of the default performance path, which favors layout correctness/clipping over possibleSurfaceViewperformance optimizations.Fixes #4
Fixes #71
Fixes #250
Fixes #285