Big speed update and ADOdb from 2025#25
Open
DeyV wants to merge 21 commits intoReimuHakurei:masterfrom
Open
Conversation
Fixes "PHP Warning: sprintf(): Too few arguments in /usr/share/phpPgAdmin/classes/Misc.php on line 1346" in version "phpPgAdmin 5.6" The same problem was present in both swedish & danish translations Seems to have been a longstanding problem according to https://sourceforge.net/p/phppgadmin/bugs/430/ --------- Authored-by: Peje Nilsson <peje@irf.se>
# Conflicts: # classes/database/Postgres.php # colproperties.php # libraries/adodb/drivers/adodb-postgres64.inc.php # libraries/decorator.inc.php
# Conflicts: # classes/database/Connection.php
DeyV
changed the title
Owner
|
The change in classes/database/Connection.php is not necessary, as the default behavior is already to fall back to the latest driver version. What is the purpose of the change in colproperties.php? |
$_REQUEST['default'] = '' is not required
Author
it wasn't necessary. I withdrew it
its better to have logic about one aspect in one place, not scattered around different places in the code. Therefore, I think it is better to leave it here as proposed |
Extended allowed database versions to allow connections to v15 and v16 postgres versions using latest connector class. Tested in practice, works to certain extent.
# Conflicts: # classes/database/Connection.php
# Conflicts: # libraries/adodb/adodb.inc.php # libraries/adodb/docs/changelog.md
DeyV
changed the title
Author
|
@ReimuHakurei What You think? |
ROBERT-MCDOWELL
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.