Remove deprecated argument from const definitions#32
Open
kitserve wants to merge 1 commit intoReimuHakurei:masterfrom
Open
Remove deprecated argument from const definitions#32kitserve wants to merge 1 commit intoReimuHakurei:masterfrom
kitserve wants to merge 1 commit intoReimuHakurei:masterfrom
Conversation
The third argument, `case_insensitive`, to `define` was deprecated in PHP 7.3.0 and generates a warning in PHP 8.0.0+. This commit removes the argument, to prevent spurious warnings. It also removes trailing whitespace and the PHP close tag at the end of the file, in line with best practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third argument,
case_insensitive, to thedefinefunction was deprecated in PHP 7.3.0 and generates a warning in PHP 8.0.0+. This commit removes the argument, to prevent spurious warnings. It also removes trailing whitespace and the PHP close tag at the end of the file, in line with best practice.