Cleanup test bound gems from runtime environment#3
Open
lucasmartins wants to merge 2 commits intoResultadosDigitais:masterfrom
Open
Cleanup test bound gems from runtime environment#3lucasmartins wants to merge 2 commits intoResultadosDigitais:masterfrom
lucasmartins wants to merge 2 commits intoResultadosDigitais:masterfrom
Conversation
|
@lucasmartins I'm pretty sure you didn't want to include readme here |
anacaet
suggested changes
Sep 27, 2016
anacaet
left a comment
There was a problem hiding this comment.
The README file can't be approved because is pointing to another repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've just moved
webmock&coverallsfromruntime_dependencytodevelopment_dependencyon the gemspec.This was adding test gems to the production environment, which breaks my heart. 💔
Any thoughts?