Skip to content

I think i found the 8 bugs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RexTheBeast wants to merge 1 commit into
base: main
Choose a base branch
from
Open

I think i found the 8 bugs #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ <h1>Guessing Game</h1>
less?
</p>
<div>
<input type="number" id="guess" min="1" max="99" />
<!-- 8 bug max should be 100 no 99 -->
<input type="number" id="guess" min="1" max="100" />
<button id="submit">Submit Guess</button>
</div>
<div>
Expand Down
25 changes: 14 additions & 11 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ const correctMessage = document.getElementById('correct');

let targetNumber;
let attempts = 0;
const maxNumberOfAttempts = 5;
//bug 3 should be var not const if it will change later
var maxNumberOfAttempts = 5;

// Returns a random number from min (inclusive) to max (exclusive)
// Usage:
Expand Down Expand Up @@ -38,21 +39,21 @@ function checkGuess() {
submitButton.disabled = true;
guessInput.disabled = true;
}

//4th bug never shows to big
if (guess !== targetNumber) {
if (guess < targetNumber) {
tooLowMessage.style.display = '';
} else {
tooLowMessage.style.display = '';
tooHighMessage.style.display = '';
}

const remainingAttempts = maxNumberOfAttempts - attempts;

numberOfGuessesMessage.style.display = '';
numberOfGuessesMessage.innerHTML = `You guessed ${guess}. <br> ${remainingAttempts} guesses remaining`;
}

if (attempts ==== maxNumberOfAttempts) {
//1st bug not ==== incorrect
if (attempts === maxNumberOfAttempts) {
submitButton.disabled = true;
guessInput.disabled = true;
}
Expand All @@ -62,22 +63,24 @@ function checkGuess() {
resetButton.style.display = '';
}

//5th bug was not working <= will mean index goes past the length of message
function hideAllMessages() {
for (let elementIndex = 0; elementIndex <= messages.length; elementIndex++) {
for (let elementIndex = 0; elementIndex < messages.length; elementIndex++) {
messages[elementIndex].style.display = 'none';
}
}

funtion setup() {
//bug 2 function splled wrong
function setup() {
// Get random number
targetNumber = getRandomNumber(1, 100);
console.log(`target number: ${targetNumber}`);

//6th bug basicly resets the whole attmps so you never win need
// Reset number of attempts
maxNumberOfAttempts = 0;
attempts = 0;

//bug 7 wrong spelling
// Enable the input and submit button
submitButton.disabeld = false;
submitButton.disabled = false;
guessInput.disabled = false;

hideAllMessages();
Expand Down