fix: handle edge case annual fee patterns for United Explorer and Marriott Bountiful#14
Open
moltbot0912 wants to merge 1 commit intoRich627:mainfrom
Open
fix: handle edge case annual fee patterns for United Explorer and Marriott Bountiful#14moltbot0912 wants to merge 1 commit intoRich627:mainfrom
moltbot0912 wants to merge 1 commit intoRich627:mainfrom
Conversation
…riott Bountiful - Add pattern for '/bin/zsh intro annual fee for the first year, then ' format - Add KNOWN_ANNUAL_FEES fallback for cards where scraping fails - United Explorer: (after intro year) - Marriott Bonvoy Bountiful:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI was failing because schema validation detected
nullannual fees for:Root Cause
The
extractAnnualFeefunction didn't handle these edge cases:Solution
KNOWN_ANNUAL_FEESfallback lookup table for cards where scraping failsChanges
Functions/scraper/scrapers/chase.js: Added new pattern + fallback mechanismTesting
These changes will fix the validation errors and allow CI to pass.