Updates to support docker compose and .NET 6.0#15
Open
LeeHolmes wants to merge 1 commit intoRickStrahl:masterfrom
Open
Updates to support docker compose and .NET 6.0#15LeeHolmes wants to merge 1 commit intoRickStrahl:masterfrom
LeeHolmes wants to merge 1 commit intoRickStrahl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds changes I had to make to get this working against .NET 6.0 and current 'docker compose'.
Changes were:
docker-compose.yml - changed the context to one level lower, since its dockerfile could not reference the wwwroot contents in a parent directory. Also stopped exposing port 5000, since nginx only needs to talk to that port via the bridge network.
nginx/Dockerfile - changed the relative paths to handle the new context. I was not able to update the 'COPY wwwroot' statement to refer to a parent directory ("../AlbumViewer...")
nginx.conf - Changed the upstream server to use the bridge network relative name, as this line was causing nginx to try to access port 5000 on the nginx container (rather than the westwindalbumviewer container).
AlbumViewerNetCore/Dockerfile - Moved to latest ASP.Net image (including related release path), and stopped remapping the API server to 80 since this is internal only.