Add from field to notification#52
Open
bienvenidosaez wants to merge 1 commit intoRidersDiscountCom:masterfrom
Open
Add from field to notification#52bienvenidosaez wants to merge 1 commit intoRidersDiscountCom:masterfrom
bienvenidosaez wants to merge 1 commit intoRidersDiscountCom:masterfrom
Conversation
|
I believe from is a reserved word in python so the parameter can't be named from. There is also a 64 character limit for the from property in HipChat's API and passing a string larger would cause this to fail. Maybe take the first 64 characters if the input is larger than 64 characters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.